Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing form_errors for identifiable object forms #14172

Merged
merged 2 commits into from Jun 13, 2019
Merged

Add missing form_errors for identifiable object forms #14172

merged 2 commits into from Jun 13, 2019

Conversation

sarjon
Copy link
Contributor

@sarjon sarjon commented Jun 12, 2019 •
edited by eternoendless

Questions Answers
Branch? 1.7.6.x
Description? See issue.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #14103
How to test? I think it's not needed.

This change is Reviewable

@sarjon sarjon requested a review from a team as a code owner June 12, 2019 13:27
@prestonBot prestonBot added 1.7.6.x Branch Bug Type: Bug labels Jun 12, 2019
@matks matks added this to the 1.7.6.0 milestone Jun 12, 2019
@matks matks added the migration symfony migration project label Jun 12, 2019
@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: action required, waiting for test feedback label Jun 13, 2019
@matks matks removed the Waiting for QA Status: action required, waiting for test feedback label Jun 13, 2019
@matks
Copy link
Contributor

matks commented Jun 13, 2019

No QA needed as it is for errors added by modules so it cant be seen

@matks
Copy link
Contributor

matks commented Jun 13, 2019

Thanks @sarjon

@matks matks merged commit 842cc25 into PrestaShop:1.7.6.x Jun 13, 2019
@matks matks mentioned this pull request Jun 13, 2019
Closed
@sarjon sarjon deleted the add-missing-form-errors branch June 13, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
1.7.6.x Branch Bug Type: Bug migration symfony migration project
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sarjon @matks @PierreRambaud @Quetzacoalt91 @prestonBot