Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQL error due do while not ended #14273

Merged
merged 1 commit into from Jun 20, 2019
Merged

Fix SQL error due do while not ended #14273

merged 1 commit into from Jun 20, 2019

Conversation

123monsite-regis
Copy link
Contributor

@123monsite-regis 123monsite-regis commented Jun 18, 2019 •
edited

Questions Answers
Branch? develop
Description? Bad while end condition , array_pop end at 1
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? sorry, no
How to test? please see below

image

This change is Reviewable

@123monsite-regis 123monsite-regis requested a review from a team as a code owner June 18, 2019 14:25
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Jun 18, 2019
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Jun 19, 2019
@matks matks added this to the 1.7.7.0 milestone Jun 19, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 20, 2019
@Quetzacoalt91 Quetzacoalt91 merged commit 3a819a9 into PrestaShop:develop Jun 20, 2019
@Quetzacoalt91
Copy link
Member

Thank you @123monsite-regis

@eternoendless eternoendless changed the title CO: Fix Sql Error due do while not ended Fix SQL error due do while not ended Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@123monsite-regis @Quetzacoalt91 @PierreRambaud @matks @sarahdib @prestonBot