Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removed templates for mail dynamic contents, order mails mainl… #14601

Merged
merged 4 commits into from Jul 31, 2019

Conversation

@jolelievre
Copy link
Contributor

commented Jul 11, 2019

Questions Answers
Branch? develop
Description? Revert removed templates for mail dynamic contents, order mails mainly, create MailPartialTemplateRenderer to manage this feature. Also fix the HookDispatcher which ignored events with any uppercase
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? Test an order and check that the email is correctly sent (with the product list). You can also go to Design > Email Theme and check the order_conf preview

This change is Reviewable

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 11, 2019

@jolelievre jolelievre force-pushed the jolelievre:fix-order-conf branch from f80178c to 88220ae Jul 12, 2019

Revert removed templates for mail dynamic contents, order mails mainl…
…y, create MailPartialTemplateRenderer to manage this feature

@jolelievre jolelievre force-pushed the jolelievre:fix-order-conf branch from 88220ae to 9e1f94d Jul 12, 2019

@jolelievre jolelievre force-pushed the jolelievre:fix-order-conf branch from dfee3e5 to d0dcab7 Jul 12, 2019

@PierreRambaud
Copy link
Contributor

left a comment

See comments

jolelievre added some commits Jul 16, 2019

@jolelievre jolelievre added this to the 1.7.7.0 milestone Jul 16, 2019

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@PierreRambaud I think it's alright!

@jolelievre jolelievre added this to To be reviewed in PrestaShop 1.7.7 Jul 31, 2019

@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.7 Jul 31, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 31, 2019

@sarahdib sarahdib moved this from To be tested to To be merged in PrestaShop 1.7.7 Jul 31, 2019

@PierreRambaud PierreRambaud merged commit 9dbde03 into PrestaShop:develop Jul 31, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Thanks @jolelievre

@marionf marionf moved this from To be merged to Done in PrestaShop 1.7.7 Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.