Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert removed templates for mail dynamic contents, order mails mainly, create MailPartialTemplateRenderer to manage this feature #14601

Merged
merged 4 commits into from Jul 31, 2019
Merged

Revert removed templates for mail dynamic contents, order mails mainly, create MailPartialTemplateRenderer to manage this feature #14601

merged 4 commits into from Jul 31, 2019

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Jul 11, 2019 •
edited

Questions Answers
Branch? develop
Description? Revert removed templates for mail dynamic contents, order mails mainly, create MailPartialTemplateRenderer to manage this feature. Also fix the HookDispatcher which ignored events with any uppercase
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? Test an order and check that the email is correctly sent (with the product list). You can also go to Design > Email Theme and check the order_conf preview

This change is Reviewable

@jolelievre jolelievre requested a review from a team as a code owner July 11, 2019 23:39
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Jul 11, 2019
@jolelievre
Revert removed templates for mail dynamic contents, order mails mainl…
9e1f94d 
…y, create MailPartialTemplateRenderer to manage this feature
PierreRambaud
PierreRambaud suggested changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@jolelievre jolelievre added this to the 1.7.7.0 milestone Jul 16, 2019
@jolelievre
Copy link
Contributor Author

@PierreRambaud I think it's alright!

@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jul 17, 2019
@jolelievre jolelievre added this to To be reviewed in PrestaShop 1.7.7.3 Jul 31, 2019
@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.7.3 Jul 31, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 31, 2019
@sarahdib sarahdib moved this from To be tested to To be merged in PrestaShop 1.7.7.3 Jul 31, 2019
@PierreRambaud PierreRambaud merged commit 9dbde03 into PrestaShop:develop Jul 31, 2019
@PierreRambaud
Copy link
Contributor

Thanks @jolelievre

@marionf marionf moved this from To be merged to Done in PrestaShop 1.7.7.3 Aug 1, 2019
@jolelievre jolelievre deleted the fix-order-conf branch October 15, 2019 08:13
@eternoendless eternoendless changed the title Revert removed templates for mail dynamic contents, order mails mainl… Revert removed templates for mail dynamic contents, order mails mainly, create MailPartialTemplateRenderer to manage this feature Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jolelievre @PierreRambaud @sarahdib @prestonBot