Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules translations files in theme erased by modules translations that are in modules folder. #14609

Merged
merged 3 commits into from Sep 5, 2019

Conversation

@bm-services
Copy link

commented Jul 12, 2019

Questions Answers
Branch? develop
Description? Modules translations files in theme erased by modules translations are in modules folder.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14570
How to test? Create a translations for a module in classic theme: themes/classic/modules/marketplace/translations/fr.php and edit a translation.

This change is Reviewable

@bm-services bm-services requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 12, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Hello @bm-services!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 12, 2019
@PierreRambaud PierreRambaud changed the title Issue 14570 Modules translations files in theme erased by modules translations that are in modules folder. Jul 26, 2019
@sarahdib sarahdib self-assigned this Jul 31, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 4, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Thank you @bm-services

@matks matks merged commit 06ed8a1 into PrestaShop:develop Sep 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.