Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modules translations files in theme erased by modules translations that are in modules folder #14609

Merged
merged 3 commits into from Sep 5, 2019
Merged

Fix modules translations files in theme erased by modules translations that are in modules folder #14609

merged 3 commits into from Sep 5, 2019

Conversation

bm-services
Copy link

@bm-services bm-services commented Jul 12, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Modules translations files in theme erased by modules translations are in modules folder.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14570
How to test? Create a translations for a module in classic theme: themes/classic/modules/marketplace/translations/fr.php and edit a translation.

This change is Reviewable

@bm-services bm-services requested a review from a team as a code owner July 12, 2019 09:15
@prestonBot
Copy link
Collaborator

Hello @bm-services!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Jul 12, 2019
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jul 12, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 12, 2019
@PierreRambaud PierreRambaud changed the title Issue 14570 Modules translations files in theme erased by modules translations that are in modules folder. Jul 26, 2019
@sarahdib sarahdib self-assigned this Jul 31, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 4, 2019
@matks
Copy link
Contributor

matks commented Sep 5, 2019

Thank you @bm-services

@matks matks merged commit 06ed8a1 into PrestaShop:develop Sep 5, 2019
@khouloudbelguith khouloudbelguith mentioned this pull request Sep 6, 2019
Closed
@eternoendless eternoendless changed the title Modules translations files in theme erased by modules translations that are in modules folder. Fix modules translations files in theme erased by modules translations that are in modules folder Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees

@sarahdib sarahdib

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

Translations: Priority to apply module translations files in theme
6 participants
@bm-services @prestonBot @matks @PierreRambaud @sarahdib @audebms