Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move i18n.prestashop.net into https and remove unwanted file #14859

Merged
merged 1 commit into from Jul 31, 2019
Merged

Move i18n.prestashop.net into https and remove unwanted file #14859

merged 1 commit into from Jul 31, 2019

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jul 25, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Force i18n.prestashop.net to be in https and remove unwanted cldr file
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? Install languages and emails packs.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 25, 2019
@PierreRambaud PierreRambaud requested a review from a team as a code owner July 25, 2019 16:09
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Jul 25, 2019
eternoendless
eternoendless approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@eternoendless eternoendless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the whole release folder is obsolete, we can delete it in another PR

@eternoendless eternoendless added the Waiting for QA Status: action required, waiting for test feedback label Jul 26, 2019
@sarahdib sarahdib self-assigned this Jul 31, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 31, 2019
@PierreRambaud PierreRambaud merged commit 3cb8613 into PrestaShop:develop Jul 31, 2019
@PierreRambaud PierreRambaud deleted the https-and-remove-cldr branch July 31, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternoendless eternoendless eternoendless approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees

@sarahdib sarahdib

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@PierreRambaud @eternoendless @TomaszGasior @Progi1984 @sarahdib @prestonBot