Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect last visit date in the customer grid #15005

Merged
merged 1 commit into from Aug 19, 2019
Merged

Fix incorrect last visit date in the customer grid #15005

merged 1 commit into from Aug 19, 2019

Conversation

cirykpopeye
Copy link
Contributor

@cirykpopeye cirykpopeye commented Aug 6, 2019

Questions Answers
Branch? develop
Description? Last visit date was incorrect, it used the date_add from the customer table while it should use the connections table.
Type? bug fix
BC breaks? no
Category BO
Deprecations? no
How to test? In the customer table, try login back in on the frontend and you will not see the last visit date change, with this fix you will.

This change is Reviewable

Last visit date was incorrect, it used the date_add from the customer table while it should use the connections table.
@cirykpopeye cirykpopeye requested a review from a team as a code owner August 6, 2019 15:01
@prestonBot
Copy link
Collaborator

Hello @cirykpopeye!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Aug 6, 2019
@cirykpopeye
Copy link
Contributor Author

Hi!

Your pull request description seems to be incomplete or malformed:

  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Ok, this was updated.

@PierreRambaud
Copy link
Contributor

ping @sarjon Wdyt?

@sarjon
Copy link
Contributor

sarjon commented Aug 15, 2019

Yup, makes sense. 👍

@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Aug 15, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 19, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 19, 2019
@sarahdib sarahdib self-assigned this Aug 19, 2019
@PierreRambaud PierreRambaud merged commit 50776cd into PrestaShop:develop Aug 19, 2019
@PierreRambaud
Copy link
Contributor

Thanks @cirykpopeye

@eternoendless eternoendless changed the title Last visit date incorrect Fix incorrect last visit date in the customer grid Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants