Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last visit date incorrect #15005

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@cirykpopeye
Copy link
Contributor

commented Aug 6, 2019

Questions Answers
Branch? develop
Description? Last visit date was incorrect, it used the date_add from the customer table while it should use the connections table.
Type? bug fix
BC breaks? no
Category BO
Deprecations? no
How to test? In the customer table, try login back in on the frontend and you will not see the last visit date change, with this fix you will.

This change is Reviewable

Last visit date was incorrect, it used the date_add from the customer table while it should use the connections table.
@cirykpopeye cirykpopeye requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 6, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Hello @cirykpopeye!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Hi!

Your pull request description seems to be incomplete or malformed:

  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@cirykpopeye

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Hi!

Your pull request description seems to be incomplete or malformed:

  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Ok, this was updated.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

ping @sarjon Wdyt?

@sarjon

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Yup, makes sense. 👍

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 19, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 19, 2019
@sarahdib sarahdib self-assigned this Aug 19, 2019
@PierreRambaud PierreRambaud merged commit 50776cd into PrestaShop:develop Aug 19, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Thanks @cirykpopeye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.