Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to edit address alias during checkout #15216

Merged
merged 1 commit into from Sep 27, 2019
Merged

Allow users to edit address alias during checkout #15216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions themes/classic/templates/checkout/_partials/address-form.tpl
View file
Open in desktop
@@ -1,8 +1,8 @@
{extends file='customer/_partials/address-form.tpl'}

{block name='form_field'}
{if $field.name eq "alias"}
{* we don't ask for alias here *}
{if $field.name eq "alias" and $customer.is_guest}
{* we don't ask for alias here if customer is not registered *}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, codewise, but I'll wait for the PM team's opinion before approving your PR. Thanks !

{else}
{$smarty.block.parent}
{/if}
Expand Down