Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category_name to SearchResultProductFilter whitelist, fix [BOOM-4639] / issue 9767 #15352

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@JulianEberius
Copy link
Contributor

commented Sep 1, 2019

Questions Answers
Branch? develop
Description? This should fix #9767 . The reason the search box does not work correctly (even in the live demo at http://demo.prestashop.com !) is that the category_name attribute is filtered in ProductListingFrontController using the SearchResultProductFilter.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9767
How to test? Use the default search box, see the categories are missing (all items starting with ">"). Apply fix, they should appear again.

This change is Reviewable

@JulianEberius JulianEberius requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 1, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

Hello @JulianEberius!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Copy link
Contributor

left a comment

Thank you @JulianEberius !

From what I've checked in the code, your modification looks good to me.

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 5, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Sep 5, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Thank you @JulianEberius

@matks matks merged commit 6a281f4 into PrestaShop:develop Sep 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.