Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quicksearch results missing the category name #15352

Merged
merged 1 commit into from Sep 5, 2019
Merged

Fix quicksearch results missing the category name #15352

merged 1 commit into from Sep 5, 2019

Conversation

JulianEberius
Copy link
Contributor

@JulianEberius JulianEberius commented Sep 1, 2019 •
edited by marionf

Questions Answers
Branch? develop
Description? This should fix #9767 . The reason the search box does not work correctly (even in the live demo at http://demo.prestashop.com !) is that the category_name attribute is filtered in ProductListingFrontController using the SearchResultProductFilter.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9767
How to test? Use the default search box, see the categories are missing (all items starting with ">"). Apply fix, they should appear again.

This change is Reviewable

@JulianEberius JulianEberius requested a review from a team as a code owner September 1, 2019 21:27
@prestonBot
Copy link
Collaborator

Hello @JulianEberius!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Sep 1, 2019
matthieu-rolland
matthieu-rolland approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JulianEberius !

From what I've checked in the code, your modification looks good to me.

@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Sep 4, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 5, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Sep 5, 2019
@matks
Copy link
Contributor

matks commented Sep 5, 2019

Thank you @JulianEberius

@matks matks merged commit 6a281f4 into PrestaShop:develop Sep 5, 2019
@eternoendless eternoendless changed the title Add category_name to SearchResultProductFilter whitelist, fix [BOOM-4639] / issue 9767 Fix quicksearch results missing the category name Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

[BOOM-4639] Quicksearch dropdown is missing the category name
6 participants
@JulianEberius @prestonBot @matks @PierreRambaud @matthieu-rolland @sarahdib