Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate retrieval of attributes color list #15371

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@lvancrayelynghe
Copy link
Contributor

commented Sep 2, 2019

Questions Answers
Branch? develop
Description? Prevent calling Product::getAttributesColorList() twice, which contain heavy SQL queries
Category? CO
Type? improvement / refacto
BC breaks? no
Deprecations? no

This change is Reviewable

@lvancrayelynghe lvancrayelynghe requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 2, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Sep 2, 2019

Hello @lvancrayelynghe!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

No QA needed. One more approve and merge.

@matks
matks approved these changes Sep 3, 2019
@matks matks added this to the 1.7.7.0 milestone Sep 3, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Thank you @lvancrayelynghe lvancrayelynghe

@matks matks merged commit e66d7c4 into PrestaShop:develop Sep 3, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.