Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate retrieval of attributes color list #15371

Merged
merged 1 commit into from Sep 3, 2019
Merged

Fix duplicate retrieval of attributes color list #15371

merged 1 commit into from Sep 3, 2019

Conversation

lvancrayelynghe
Copy link
Contributor

@lvancrayelynghe lvancrayelynghe commented Sep 2, 2019 •
edited by jolelievre

Questions Answers
Branch? develop
Description? Prevent calling Product::getAttributesColorList() twice, which contain heavy SQL queries
Type? refacto
Category? CO
BC breaks? no
Deprecations? no

This change is Reviewable

@lvancrayelynghe lvancrayelynghe requested a review from a team as a code owner September 2, 2019 23:28
@prestonBot
Copy link
Collaborator

Hello @lvancrayelynghe!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 2, 2019
@PierreRambaud
Copy link
Contributor

No QA needed. One more approve and merge.

@matks matks added this to the 1.7.7.0 milestone Sep 3, 2019
@matks
Copy link
Contributor

matks commented Sep 3, 2019

Thank you @lvancrayelynghe lvancrayelynghe

@matks matks merged commit e66d7c4 into PrestaShop:develop Sep 3, 2019
@prestonBot prestonBot added the Refactoring Type: Refactoring label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement Refactoring Type: Refactoring
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lvancrayelynghe @prestonBot @PierreRambaud @matks