Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] Fix the PS_ALLOW_ACCENTED_CHARS_URL bug #165

Closed
wants to merge 3 commits into from

Conversation

Shagshag
Copy link
Contributor

@Shagshag Shagshag commented Jan 8, 2013

In Prestashop < 1.5.3 utf8 chars was allowed in URL (it was a good thing btw)
In Prestashop >= 1.5.3 no more but rewrited URL are not modified
so if you simply do

$p = new Product((int) $id_product, (int) $id_lang);
$p->save();

you can have an exception : "Property Product->link_rewrite is not valid"

In Prestashop < 1.5.3 utf8 chars was allowed in URL (it was a good thing btw)
In Prestashop >= 1.5.3 no more but rewrited URL are not modified 
so if you simply do
```PHP
$p = new Product((int) $id_product, (int) $id_lang);
$p->save();
```
you can have an exception : "Property Product->link_rewrite is not valid"
@@ -5171,3 +5189,5 @@ public static function getIdByEan13($ean13)
}
}

= '.(int)$interval['nright']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is those lines ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know :-(

@vAugagneur
Copy link
Contributor

Hi,

Since 1.5.3.1 there is an option to allow accented chars in SEO & URL page.
Moreover adding this code in the construct won't be the solution, just enable the option in SEO & URL and you won't have any error message

Regards

@vAugagneur vAugagneur closed this Apr 23, 2013
marionf pushed a commit to marionf/PrestaShop that referenced this pull request Oct 8, 2021
…correct-outside-root

Ignored files incorrect outside root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants