Fix a bug where changing quantity on product quickview adds products tags on every product #16852

NeOMakinG · 2019-12-18T15:50:09Z

Questions	Answers
Branch?	1.7.6.x
Description?	When you were on product quickview, it was adding tags of the viewed product on every products on the page
Type?	bug fix
Category?	FO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #16633 and Fixes #9919
How to test?	Go on the homepage, and click on quickview on a product with a promo tag for example, then change quantity and see if others product has the tag on the page

This change is

themes/_core/js/product.js

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>

NeOMakinG · 2019-12-19T10:48:11Z

I should rebuild assets, don't approve yet

themes/_core/js/product.js

khouloudbelguith · 2019-12-19T15:06:18Z

Hi @NeOMakinG,

It is ok in the Categories page but if you follow these steps, the issue is reproduced:

Create a product
Add some related products, which they have some labels, to the last product created
Go to the FO => Product details page
YOU MIGHT ALSO LIKE section, click the "quick view" button for the "pack" or "on sale" labeled related product,
See error

Before

After

https://drive.google.com/file/d/1XSu23m1bZeDPLysiMoMqpP1T7AvOt2h1/view

Thanks!

arouiadib · 2019-12-27T00:09:24Z

themes/_core/js/product.js

+        $('.quickview .product-discounts, .page-product:not(.modal-open) .row .product-discounts').replaceWith(data.product_discounts);
+        $('.quickview .product-additional-info, .page-product:not(.modal-open) .row .product-additional-info').replaceWith(data.product_additional_info);
+        $('.quickview #product-details, #product-details').replaceWith(data.product_details);
+        $('.quickview .product-flags, .page-product:not(.modal-open) .row .product-flags').replaceWith(data.product_flags)


I don't find any element with class .product-flags inside the quickview. Consequently, I think this line should only be: $('.page-product .product-flags').replaceWith(data.product_flags).

Same thing apply to #product-details, .product-discounts and .product-additionnal-info, because quickview doesn't contain them.

BUT this will not fully resolve the problem. One case is: when quantity is changed from a quickview inside a product page (when product miniatures exist in product page e.g similar products).

Let's take an example in detail:

user is in product X page and there are other similar products Y and Z as miniatures in sidebar.

user clicks in quickview of Y and changes quantity.

In this DOM, there are :

2 elements with class product-variants , one in quickview of Y and the other in product page X.

2 with .product-prices

1 element with .product-customization but for product X

1 element with #product-details but for product X

1 element with .product-discounts but for product X

1 element with .product-additionnal-info but for product X.

IMHO, the whole problem could be solved by re-naming classes (or adding discriminator ones) depending on the source (quickview or product page) and keeping javascript as it is for all classes.

I agree for the class not contained in quickview, gonna add a commit for it, but for the rest, did you see that I select elements on product X page only if there are no modals opened? It means that product infos will change only if there are no quickview opened

Thank you for the time you gave to my comment, and I am sorry for wrongly expressing the second point.

I should have been only focusing on .product-flags when giving my example, so let's see an example with this class:

1- Install featured products module and hook it inside product page (footer for example).
2. From product page of product X, click on quickview of product Y( anyone from featured products and not necessarly one with special flags), change quantity...etc
3. Look at product flags of featured products and product X, they change to flags of product Y.

Now, let's keep modal closed and only change quantity for productX => all featured products have their flags changed.

I agree with you that :not(.open-modal) is the solution for the majority of classes, but not all of them.

Hey, ok this time it looks like you didn't see the .row selector, featured products and product in the same category are not in a .row. I agree with you, thats not really solid, but atleast it avoid breaking changes, we are not able to change JS selectors for a new class because if we would do that, theme which herit these templates or rewrited these but didn't modify the JS would break with a new class, we're able to do it in a major version probably.

Thank you for your feedback and the time you take on this PR :)

You pointed me to subject I am not always aware of. Thank you very much for such an invaluable info.

No problem, you'r welcome, thanks a lot for your feedback there, it was a pleasure !

Robin-Fischer-PS · 2020-01-03T10:26:12Z

Hi @NeOMakinG !

The fix is OK for #16633, but I still have the bug for #9919 (comment)
Each time I modify in quickview a "You might also like" product (quantity, attribute...), an error is displayed on the product.

…view

NeOMakinG · 2020-01-03T14:08:28Z

The error is now displayed in the right place, but the error is related to something else, submit an issue if this error should be fixed by a backend dev

themes/_core/js/product.js

PierreRambaud · 2020-01-08T17:18:48Z

I don't know why PrettyCi is failing when there are only js files edited 😅

jolelievre · 2020-01-08T17:49:25Z

Yep, that's weird.. @NeOMakinG maybe you can try to squash all the commits (this will make the PR cleaner) and re-push to relaunch the PrettyCi build

Robin-Fischer-PS · 2020-01-10T15:58:17Z

Hi @NeOMakinG !

So, could you confirm me that the fact this error is still displayed (when changing combination of a "related product") should not be fixed by your PR ? If so, I would suggest to close the issue #16633 , which is totally fixed by your PR, but to keep #9919 (comment) open, since it's not totally fixed... WDYT ?

NeOMakinG · 2020-01-10T16:09:59Z

We can keep #9919 as it's related to the url called using ajax and not misplacement of ajax calls as this issue should fix, but 16633 is fixed, the error is even displayed on the product it should be displayed now

Robin-Fischer-PS · 2020-01-10T16:16:07Z

Ok ! So since the error of #9919 is now OK (only displayed on the good product), it's QA approved :)

PierreRambaud · 2020-01-10T16:18:20Z

Thanks @NeOMakinG

More precise selector on ajax change on product

e18ed1d

NeOMakinG requested a review from a team as a code owner December 18, 2019 15:50

prestonBot added the Bug Type: Bug label Dec 18, 2019

PierreRambaud reviewed Dec 19, 2019

View reviewed changes

themes/_core/js/product.js Outdated Show resolved Hide resolved

Id must be unique, removing useless precise selector

a9f874e

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>

PierreRambaud reviewed Dec 19, 2019

View reviewed changes

themes/_core/js/product.js Outdated Show resolved Hide resolved

prestonBot added the 1.7.6.x Branch label Dec 19, 2019

PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Dec 19, 2019

PierreRambaud previously approved these changes Dec 19, 2019

View reviewed changes

khouloudbelguith added Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 19, 2019

Valentin Szczupak added 3 commits December 20, 2019 09:56

Deeper selector to avoid conflict

9fd6945

Deeper selector to avoid conflict

1d75ecb

Fix conflict

fa6b118

NeOMakinG dismissed PierreRambaud’s stale review via fa6b118 December 20, 2019 09:04

remove unwanted console log

e6468c2

NeOMakinG removed Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Dec 20, 2019

NeOMakinG requested a review from PierreRambaud December 20, 2019 09:05

arouiadib reviewed Dec 27, 2019

View reviewed changes

matks previously approved these changes Dec 30, 2019

View reviewed changes

matks added the Waiting for QA Status: action required, waiting for test feedback label Dec 30, 2019

Robin-Fischer-PS self-assigned this Jan 3, 2020

Robin-Fischer-PS added Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 3, 2020

Displaying error on the right place instead of product page and quick…

eded242

…view

NeOMakinG dismissed matks’s stale review via eded242 January 3, 2020 14:07

NeOMakinG requested a review from matks January 3, 2020 14:07

NeOMakinG removed Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Jan 3, 2020

Robin-Fischer-PS added Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 3, 2020

NeOMakinG removed the Waiting for dev Status: action required, waiting for tech feedback label Jan 7, 2020

PierreRambaud reviewed Jan 8, 2020

View reviewed changes

themes/_core/js/product.js Outdated Show resolved Hide resolved

Forgot to remove a console log

c768777

PierreRambaud approved these changes Jan 8, 2020

View reviewed changes

PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jan 8, 2020

PierreRambaud added this to the 1.7.6.3 milestone Jan 8, 2020

Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 10, 2020

PierreRambaud merged commit 39e5e9e into PrestaShop:1.7.6.x Jan 10, 2020

marionf mentioned this pull request Jan 10, 2020

Quickview and product flags bug #16633

Closed

khouloudbelguith mentioned this pull request Jan 23, 2020

Combination / Attributes - bad refresh at product detail #17289

Closed

eternoendless mentioned this pull request Jun 10, 2020

Broken theme after 1.7.6.3 update #19661

Closed

eternoendless changed the title ~~Fix a bug where changing quantity on product quickview adds products tags on ever products~~ Fix a bug where changing quantity on product quickview adds products tags on every products Jun 10, 2020

eternoendless changed the title ~~Fix a bug where changing quantity on product quickview adds products tags on every products~~ Fix a bug where changing quantity on product quickview adds products tags on every product Jun 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix a bug where changing quantity on product quickview adds products tags on every product #16852

Fix a bug where changing quantity on product quickview adds products tags on every product #16852

NeOMakinG commented Dec 18, 2019 •

edited

NeOMakinG commented Dec 19, 2019

khouloudbelguith commented Dec 19, 2019

arouiadib Dec 27, 2019 •

edited

NeOMakinG Dec 27, 2019

arouiadib Dec 27, 2019 •

edited

NeOMakinG Dec 30, 2019

arouiadib Dec 30, 2019

NeOMakinG Dec 31, 2019

Robin-Fischer-PS commented Jan 3, 2020

NeOMakinG commented Jan 3, 2020

PierreRambaud commented Jan 8, 2020

jolelievre commented Jan 8, 2020

Robin-Fischer-PS commented Jan 10, 2020

NeOMakinG commented Jan 10, 2020

Robin-Fischer-PS commented Jan 10, 2020 •

edited

PierreRambaud commented Jan 10, 2020

Fix a bug where changing quantity on product quickview adds products tags on every product #16852

Fix a bug where changing quantity on product quickview adds products tags on every product #16852

Conversation

NeOMakinG commented Dec 18, 2019 • edited

NeOMakinG commented Dec 19, 2019

khouloudbelguith commented Dec 19, 2019

arouiadib Dec 27, 2019 • edited

Choose a reason for hiding this comment

NeOMakinG Dec 27, 2019

Choose a reason for hiding this comment

arouiadib Dec 27, 2019 • edited

Choose a reason for hiding this comment

NeOMakinG Dec 30, 2019

Choose a reason for hiding this comment

arouiadib Dec 30, 2019

Choose a reason for hiding this comment

NeOMakinG Dec 31, 2019

Choose a reason for hiding this comment

Robin-Fischer-PS commented Jan 3, 2020

NeOMakinG commented Jan 3, 2020

PierreRambaud commented Jan 8, 2020

jolelievre commented Jan 8, 2020

Robin-Fischer-PS commented Jan 10, 2020

NeOMakinG commented Jan 10, 2020

Robin-Fischer-PS commented Jan 10, 2020 • edited

PierreRambaud commented Jan 10, 2020

NeOMakinG commented Dec 18, 2019 •

edited

arouiadib Dec 27, 2019 •

edited

arouiadib Dec 27, 2019 •

edited

Robin-Fischer-PS commented Jan 10, 2020 •

edited