New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RTL Style for Classic Theme #17248
Conversation
@@ -0,0 +1,50 @@ | |||
#body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this file is generated and the weird indentation is normal ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, it was generated from this : https://devdocs.prestashop.com/1.7/themes/reference/rtl/#stylesheet-generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTL shouldn't be commited 🤔
ping @eternoendless
RTL BO assets should not be committed 😄 |
Actually, no script generate *_rtl file. You must need to generate them from the backoffice. For the next version, an issue #17247 has been created by @matks for automating that. |
The base branch was changed.
Hi @Progi1984 , I tested BO and FO RTL display in Arabic and Persian, with theses languages as default, and with English as default. I also tested a fresh install in Persian (because Arabic is not possible due to another bug). All my tests are OK, so it's QA ✔️ ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These assets must be generated automatically when installing the language and MUST NOT be committed unless you have a very good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok go for merging this but we need to make a decision for 1.7.7
Thank you @Progi1984 |
And develop ! 😄 |
This change is