Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't explore a category when all subcats are disabled #17395

Merged
merged 1 commit into from Feb 4, 2020
Merged

Can't explore a category when all subcats are disabled #17395

merged 1 commit into from Feb 4, 2020

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented Jan 29, 2020 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.6.x
Description? When all subcategories from a parent are disabled then it's imposible to explore the parent again.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #17379
How to test? Steps to reproduce the behavior:

Go to Catalog / Categories
Create new category
Create a new subcategory with parent category equals the previous created category.
Edit the last new category and set it to disabled.
Go to main list, then it's imposible to enter the in the "view" of the parent category, list only allows to edit it but it is not possible to explore the disabled subcategory

This change is Reviewable

@PululuK PululuK requested a review from a team as a code owner January 29, 2020 01:35
@prestonBot prestonBot added 1.7.6.x Branch Bug Type: Bug labels Jan 29, 2020
@PierreRambaud PierreRambaud changed the title [FIX] Can't explore a category when all subcats are disabled Can't explore a category when all subcats are disabled Jan 29, 2020
@prestonBot prestonBot added the develop Branch label Jan 29, 2020
@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.6.x January 29, 2020 09:16
@PierreRambaud
Copy link
Contributor

Hi @PululuK
I rebase your pull request and target the 1.7.6.x branch :)
Thanks for your contribution

@PierreRambaud PierreRambaud removed the 1.7.6.x Branch label Jan 29, 2020
@prestonBot prestonBot added the 1.7.6.x Branch label Jan 29, 2020
@PierreRambaud PierreRambaud removed the develop Branch label Jan 29, 2020
@PierreRambaud PierreRambaud added this to the 1.7.6.4 milestone Jan 29, 2020
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Jan 29, 2020
@khouloudbelguith
Copy link
Contributor

Hi @PululuK,

It is OK.
https://drive.google.com/file/d/1RFI7UCH3K5iF2l-Nnd7jxqxcVvwVNHcM/view

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 3, 2020
@Progi1984 Progi1984 merged commit 8b9df2e into PrestaShop:1.7.6.x Feb 4, 2020
@Progi1984
Copy link
Contributor

Thanks @PululuK

@Progi1984 Progi1984 mentioned this pull request Feb 4, 2020
Closed
@PululuK PululuK deleted the PululuK-patch-7 branch April 2, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
1.7.6.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PululuK @PierreRambaud @khouloudbelguith @Progi1984 @prestonBot