Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests - adding additional information to tests #17418

Merged
merged 6 commits into from Jan 31, 2020
Merged

Functional tests - adding additional information to tests #17418

merged 6 commits into from Jan 31, 2020

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented Jan 29, 2020 •
edited by eternoendless

Questions Answers
Branch? 1.7.7.x
Description? Adding additional information to steps (unique ID) to be able to target it in nightly board (and to hide tests failed 2 days in a row)
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? No tests needed

This change is Reviewable

@prestonBot prestonBot added 1.7.7.x Branch Refactoring Type: Refactoring labels Jan 29, 2020
@boubkerbribri boubkerbribri added the TE Category: Tests label Jan 30, 2020
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Jan 30, 2020
@boubkerbribri boubkerbribri marked this pull request as ready for review January 30, 2020 09:42
@boubkerbribri boubkerbribri requested a review from a team as a code owner January 30, 2020 09:42
Progi1984
Progi1984 previously approved these changes Jan 30, 2020
View reviewed changes
@boubkerbribri boubkerbribri added the WIP Status: Work In Progress label Jan 30, 2020
@boubkerbribri boubkerbribri removed the WIP Status: Work In Progress label Jan 30, 2020
@boubkerbribri boubkerbribri requested a review from a team January 30, 2020 10:52
PierreRambaud
PierreRambaud previously approved these changes Jan 30, 2020
View reviewed changes
SimonGrn
SimonGrn previously approved these changes Jan 30, 2020
View reviewed changes
PierreRambaud
PierreRambaud previously approved these changes Jan 30, 2020
View reviewed changes
@boubkerbribri
Copy link
Contributor Author

Last update : I changed context title to testIdentifier.

@SimonGrn SimonGrn merged commit 3251df3 into PrestaShop:1.7.7.x Jan 31, 2020
@boubkerbribri boubkerbribri deleted the addContextToTests branch January 31, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@SimonGrn SimonGrn SimonGrn approved these changes

@Progi1984 Progi1984 Progi1984 left review comments

Assignees
No one assigned
Labels
1.7.7.x Branch Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@boubkerbribri @PierreRambaud @Progi1984 @SimonGrn @prestonBot