Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong wordings on "New" translations #17461

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Fix wrong wordings on "New" translations #17461

merged 2 commits into from
Mar 30, 2020

Conversation

micka-fdz
Copy link
Contributor

@micka-fdz micka-fdz commented Jan 31, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? This PR fixes wrong wordings on New translations (details below)
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #17455
How to test? - New product should be use for new products (Nouveauté in french)
- New should be use for product condition (Neuf in french)

This change is Reviewable

@micka-fdz micka-fdz requested a review from a team as a code owner January 31, 2020 11:20
@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The description shouldn't be empty.
  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@LouiseBonnard LouiseBonnard added 1.7.x Branch Catalog Component: Which BO section is concerned develop Branch FO Category: Front Office Improvement Type: Improvement Wording ✔️ Status: check done, wording approved labels Jan 31, 2020
@PierreRambaud PierreRambaud added the Waiting for author Status: action required, waiting for author feedback label Jan 31, 2020
@LouiseBonnard LouiseBonnard removed the Wording ✔️ Status: check done, wording approved label Jan 31, 2020
@Progi1984
Copy link
Contributor

@micka-fdz Could you update your PR for using the contribution table ? Thanks

@micka-fdz
Copy link
Contributor Author

@Progi1984 done !

@Progi1984
Copy link
Contributor

Need "Wording ✔️" by @LouiseBonnard Before QA

@LouiseBonnard
Copy link
Contributor

It is not wording approved yet! I will ask for the QA to test it once the wording validated. ;-)

@micka-fdz
Copy link
Contributor Author

New wording is always used on product condition except on ProductLazyArray.php file.
In this file, New and New product wordings are reversed. My PR is only about to fix that.

@LouiseBonnard
Copy link
Contributor

@micka-fdz, thanks for the explanation, it is perfectly clear now! I therefore approve the wording. ;-)

As I said in #17455 (comment), the best solution might be to use New condition instead in both the back office (when selecting the condition on the 'Options' tab in the 'Product' page) and the front office (when on the 'Product Details' tab at the end of a product page). It will allow us to make sure we get a relevant translation, what do you think @micka-fdz?

@LouiseBonnard LouiseBonnard added the Wording ✔️ Status: check done, wording approved label Feb 3, 2020
@micka-fdz
Copy link
Contributor Author

@LouiseBonnard if I understand your proposal, you want to use:

  • New condition = on product condition
  • New = on new/recent products

I think it can be a good alternative but in this case, wordings have to be changed everywhere (in core but also in native modules like ps_facetedsearch).

@LouiseBonnard
Copy link
Contributor

@micka-fdz, yep, you got it, thanks a lot for the feedback! I'll create another issue to bring this idea and see how it can be applied.

@LouiseBonnard LouiseBonnard removed the Waiting for author Status: action required, waiting for author feedback label Feb 3, 2020
@matks matks added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 5, 2020
@matks
Copy link
Contributor

matks commented Feb 5, 2020

@LouiseBonnard Can we go for QA now, or not yet ?

@LouiseBonnard LouiseBonnard mentioned this pull request Feb 7, 2020
Open
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Feb 10, 2020
@SD1982 SD1982 self-assigned this Mar 30, 2020
@SD1982
Copy link
Contributor

SD1982 commented Mar 30, 2020

Hello @micka-fdz Your PR seems to do correctly what it is supposed to do but before validating it I would like to ask @LouiseBonnard opinion about the French translation for the product condition because I am not sure that this is the best term in this situation I think the translation should be "neuf" rather than "nouveau"

In English :
pr#17461 english

In French :
pr#17461 french

What do you think @LouiseBonnard ?

@SD1982 SD1982 added Waiting for author Status: action required, waiting for author feedback Waiting for PM Status: action required, waiting for product feedback Waiting for wording Status: action required, waiting for wording and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 30, 2020
@LouiseBonnard
Copy link
Contributor

LouiseBonnard commented Mar 30, 2020 •
edited

@SD1982, thanks for the ping. It is normal, it has not been merged yet so the translation is expected to be the one that formerly labels new products. :-)

I've just updated the translation on Crowdin so that New can equal Neuf instead of Nouveau, it should be okay in a couple of days.

@LouiseBonnard LouiseBonnard removed Waiting for PM Status: action required, waiting for product feedback Waiting for wording Status: action required, waiting for wording labels Mar 30, 2020
@SD1982
Copy link
Contributor

SD1982 commented Mar 30, 2020

Thanks @micka-fdz

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for author Status: action required, waiting for author feedback labels Mar 30, 2020
@Progi1984 Progi1984 merged commit 0b92e10 into PrestaShop:develop Mar 30, 2020
@Progi1984
Copy link
Contributor

Thanks @micka-fdz

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Mar 30, 2020
@Progi1984 Progi1984 mentioned this pull request Mar 30, 2020
Closed
@micka-fdz micka-fdz deleted the patch-1 branch June 29, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees

@SD1982 SD1982

Labels
1.7.x Branch Catalog Component: Which BO section is concerned develop Branch FO Category: Front Office Improvement Type: Improvement QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Use different strings for "New" translation
7 participants
@micka-fdz @prestonBot @Progi1984 @LouiseBonnard @matks @SD1982 @PierreRambaud