Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files translations.css and product_page.css do not exist #17613

Merged
merged 1 commit into from Feb 21, 2020
Merged

Files translations.css and product_page.css do not exist #17613

merged 1 commit into from Feb 21, 2020

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Feb 12, 2020 •
edited

Questions Answers
Branch? 1.7.6.x
Description? These files do not exist
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #17584
How to test? Follow ticket instruction. You don't need to use Nginx, There is no 404 in the console log.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner February 12, 2020 09:26
@prestonBot prestonBot added 1.7.7.x Branch Bug Type: Bug labels Feb 12, 2020
Progi1984
Progi1984 previously approved these changes Feb 12, 2020
View reviewed changes
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Feb 12, 2020
@Progi1984
Copy link
Contributor

@PierreRambaud Please change the base : it's 176x

@Progi1984 Progi1984 modified the milestones: 1.7.7.0, 1.7.6.4 Feb 12, 2020
@PierreRambaud PierreRambaud changed the base branch from 1.7.7.x to 1.7.6.x February 12, 2020 09:39
@PierreRambaud PierreRambaud changed the title File translations.css does not exists Files translations.css and product_page.css do not exists Feb 12, 2020
@prestonBot prestonBot added the 1.7.6.x Branch label Feb 12, 2020
@PierreRambaud PierreRambaud removed the 1.7.7.x Branch label Feb 12, 2020
@eternoendless eternoendless linked an issue Feb 12, 2020 that may be closed by this pull request
Error in the console: Failed to load product_page.css Or translations.css net::ERR_ABORTED 404 (Not Found) #17584
Closed
@Progi1984
Copy link
Contributor

@PierreRambaud Bad news : Travis is 🔴 because it is locked on the fact you are originally on the 177 branch.

image

My advice : create a new PR.

@atomiix atomiix closed this Feb 13, 2020
@atomiix atomiix reopened this Feb 13, 2020
@Progi1984
Copy link
Contributor

Thanks @atomiix

NeOMakinG
NeOMakinG approved these changes Feb 13, 2020
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeOMakinG NeOMakinG added the Waiting for QA Status: action required, waiting for test feedback label Feb 13, 2020
@PierreRambaud PierreRambaud changed the title Files translations.css and product_page.css do not exists Files translations.css and product_page.css do not exist Feb 14, 2020
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Feb 21, 2020
@Robin-Fischer-PS Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 21, 2020
@SD1982 SD1982 assigned SD1982 and unassigned Robin-Fischer-PS Feb 21, 2020
@SD1982
Copy link
Contributor

SD1982 commented Feb 21, 2020

This PR has correctly fix the console log errors described in #17613 . Thanks @PierreRambaud

@matks
Copy link
Contributor

matks commented Feb 21, 2020

Thank you @PierreRambaud

@matks matks merged commit 774fd88 into PrestaShop:1.7.6.x Feb 21, 2020
@matks matks mentioned this pull request Feb 21, 2020
Closed
@PierreRambaud PierreRambaud deleted the fix/17584 branch April 26, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@jolelievre jolelievre jolelievre approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees

@SD1982 SD1982

Labels
1.7.6.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.4
Development

Successfully merging this pull request may close these issues.

Error in the console: Failed to load product_page.css Or translations.css net::ERR_ABORTED 404 (Not Found)
9 participants
@PierreRambaud @Progi1984 @SD1982 @matks @jolelievre @NeOMakinG @atomiix @prestonBot @Robin-Fischer-PS