Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some comments in CartRuleCalculator class #17634

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix some comments in CartRuleCalculator class #17634

merged 1 commit into from
Feb 13, 2020

Conversation

arouiadib
Copy link
Contributor

@arouiadib arouiadib commented Feb 12, 2020 •
edited by matthieu-rolland

Questions Answers
Branch? develop
Description? This PR just fixes some comments.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? none
How to test? none

This change is Reviewable

@arouiadib arouiadib requested a review from a team as a code owner February 12, 2020 23:34
@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@matthieu-rolland matthieu-rolland merged commit 135522d into PrestaShop:develop Feb 13, 2020
@arouiadib arouiadib deleted the fixing-just-comments branch February 13, 2020 20:21
@matks matks added this to the 1.7.8.0 milestone Mar 9, 2020
@prestonBot prestonBot added the Improvement Type: Improvement label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arouiadib @prestonBot @Progi1984 @matthieu-rolland @matks