Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong redirection when using the quick search for a category #17920

Merged
merged 2 commits into from Mar 26, 2020
Merged

Wrong redirection when using the quick search for a category #17920

merged 2 commits into from Mar 26, 2020

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented Mar 2, 2020 •
edited

Questions Answers
Branch? 1.7.6.x
Description? In the BO, When we search a category with the quick search, we are always redirected to the Categories list page instead of the Edit category page. Tools::getPath Became obsolete after migrating the category page. You must update the URLs to the new symfony controller.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #17908.
How to test? See #17908 by @khouloudbelguith .

This change is Reviewable

@PululuK PululuK requested a review from a team as a code owner March 2, 2020 14:41
@prestonBot prestonBot added 1.7.6.x Branch Bug Type: Bug labels Mar 2, 2020
@PululuK PululuK mentioned this pull request Mar 3, 2020
Merged
jolelievre
jolelievre reviewed Mar 3, 2020
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PululuK
Nice handling of the Link::getAdminLink feature ^^
I have a suggestion for a fix that might be a bit simpler though

classes/Tools.php Outdated Show resolved Hide resolved
@PululuK PululuK closed this Mar 3, 2020
@PululuK PululuK reopened this Mar 3, 2020
jolelievre
jolelievre reviewed Mar 3, 2020
View reviewed changes
classes/Tools.php Outdated Show resolved Hide resolved
jolelievre
jolelievre previously approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PululuK

PierreRambaud
PierreRambaud suggested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is broken, please use php-cs-fixer

@PululuK
Copy link
Member Author

PululuK commented Mar 3, 2020

Indentation is broken, please use php-cs-fixer

Hi @PierreRambaud
Can you tell me where? In php file or yml ?

@jolelievre
Copy link
Contributor

@PululuK We recently disabled PrettyCI because it had some issues, and it will soon stop to work (bu the end of the year)
But we haven't reintroduced the Github action that validates code style on the 176 branch, so @PierreRambaud detects them with his super eyes!! ^^

Anyway to fix it you can just run php ./vendor/bin/php-cs-fixer fix from the root folder

@PululuK
Copy link
Member Author

PululuK commented Mar 3, 2020 •
edited

@PululuK We recently disabled PrettyCI because it had some issues, and it will soon stop to work (bu the end of the year)

Yes I am aware, I received their email! We must quickly find a tool to replace, even if I sincerely believe that the eyes of @PierreRambaud are more effective

jolelievre
jolelievre previously approved these changes Mar 4, 2020
View reviewed changes
Progi1984
Progi1984 reviewed Mar 4, 2020
View reviewed changes
classes/Tools.php Outdated Show resolved Hide resolved
Progi1984
Progi1984 reviewed Mar 4, 2020
View reviewed changes
classes/Tools.php Outdated Show resolved Hide resolved
Progi1984
Progi1984 previously approved these changes Mar 4, 2020
View reviewed changes
@jolelievre jolelievre modified the milestone: 1.7.6.4 Mar 4, 2020
@PierreRambaud PierreRambaud changed the title FIX : BO - Quick search - redirect to the Categories list page Wrong redirection when using the quick search for a category Mar 5, 2020
@PierreRambaud
Copy link
Contributor

Can you please target the 1.7.7.x branch instead of 1.7.6.x?

@PierreRambaud PierreRambaud reopened this Mar 25, 2020
@jolelievre
Copy link
Contributor

Actually the problem is not from the rebase nor this PR but some fixtures in the tests suites which are not valid any more
Here is the PR that fixes it #18309

@jolelievre
Copy link
Contributor

@PululuK I'll rebase this PR as soon as the other one is merged 😉

@PululuK
Copy link
Member Author

PululuK commented Mar 25, 2020

Actually the problem is not from the rebase nor this PR but some fixtures in the tests suites which are not valid any more
Here is the PR that fixes it #18309

You are in the future !
Thanks @jolelievre @PierreRambaud

@jolelievre jolelievre dismissed stale reviews from PierreRambaud, Progi1984, and themself via cb67cf1 March 25, 2020 14:30
@jolelievre
Copy link
Contributor

Rebased! should be good this time

@PululuK
Copy link
Member Author

PululuK commented Mar 25, 2020 •
edited

Hi @PululuK It seems that there is an issue with Travis can you check this please ?

Hi @SD1982
It is Done .. Big thanks guys @jolelievre @PierreRambaud !

@PierreRambaud PierreRambaud added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels Mar 25, 2020
@SD1982 SD1982 self-assigned this Mar 26, 2020
@SD1982
Copy link
Contributor

SD1982 commented Mar 26, 2020

This PR correctly fix #17908 ! Thanks @PululuK !

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 26, 2020
@Progi1984 Progi1984 merged commit c3dc1c7 into PrestaShop:1.7.6.x Mar 26, 2020
@Progi1984
Copy link
Contributor

Thanks @PululuK

@PululuK PululuK deleted the PululuK-patch-fix-17908 branch April 2, 2020 10:37
@Gipielle
Copy link

Hello, this fix works but is not complete,

if you click in the category link now it goes always in modify both (pencil right) and also category name (wrong) category name should go into the cateogoty so you can see list of subcategory.

@PululuK
Copy link
Member Author

PululuK commented Apr 21, 2020

Hello, this fix works but is not complete,

if you click in the category link now it goes always in modify both (pencil right) and also category name (wrong) category name should go into the cateogoty so you can see list of subcategory.

Hi @Gipielle ,

Could you open a new issue dedicated to this? Do not hesitate to tag me please!

Thank you !

@Gipielle Gipielle mentioned this pull request Apr 21, 2020
Closed
@Gipielle
Copy link

@PululuK done here #18732
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@jolelievre jolelievre jolelievre approved these changes

@matks matks Awaiting requested review from matks

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees

@SD1982 SD1982

Labels
1.7.6.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.5
Development

Successfully merging this pull request may close these issues.

BO - Quick search - redirect to the Categories list page
8 participants
@PululuK @jolelievre @PierreRambaud @Progi1984 @SD1982 @Gipielle @matks @prestonBot