Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused result in for statement #17987

Closed
wants to merge 1 commit into from
Closed

Remove unused result in for statement #17987

wants to merge 1 commit into from

Conversation

Arman-Hosseini
Copy link
Contributor

@Arman-Hosseini Arman-Hosseini commented Mar 4, 2020 •
edited by eternoendless

Questions Answers
Branch? 1.7.6.x
Description? Remove unused result in for statement
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? -

This change is Reviewable

@Arman-Hosseini Arman-Hosseini requested a review from a team as a code owner March 4, 2020 22:22
@prestonBot
Copy link
Collaborator

Hello @Arman-Hosseini!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added 1.7.6.x Branch Refactoring Type: Refactoring labels Mar 4, 2020
@Progi1984
Copy link
Contributor

Thanks @Arman-Hosseini ! Could you target your PR to the develop branch ? Thanks

@Arman-Hosseini Arman-Hosseini changed the base branch from 1.7.6.x to develop March 5, 2020 18:58
@Arman-Hosseini Arman-Hosseini changed the base branch from develop to 1.7.6.x March 5, 2020 18:59
@Arman-Hosseini Arman-Hosseini changed the base branch from 1.7.6.x to develop March 5, 2020 19:01
@Arman-Hosseini Arman-Hosseini changed the base branch from develop to 1.7.6.x March 5, 2020 19:01
@matthieu-rolland matthieu-rolland changed the base branch from 1.7.6.x to develop March 10, 2020 10:59
@matthieu-rolland matthieu-rolland changed the base branch from develop to 1.7.6.x March 10, 2020 11:00
matthieu-rolland
matthieu-rolland approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Progi1984 I think that since there will be an 1.7.6.5 anyway it's fine to do it on 1.7.6.x, it will be merged to 1.7.7 and develop eventually, what do you think?

PierreRambaud
PierreRambaud suggested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, it's not a regression, please target the develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud requested changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
1.7.6.x Branch Refactoring Type: Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Arman-Hosseini @prestonBot @Progi1984 @PierreRambaud @matthieu-rolland