Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless spaces for Ceuta and Melilla #18022

Merged
merged 1 commit into from Mar 6, 2020
Merged

Remove useless spaces for Ceuta and Melilla #18022

merged 1 commit into from Mar 6, 2020

Conversation

LouiseBonnard
Copy link
Contributor

@LouiseBonnard LouiseBonnard commented Mar 6, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Remove useless spaces in the code for Spanish states, Ceuta and Melilla
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes issue #18021
How to test? No space before the two names

This change is Reviewable

@LouiseBonnard LouiseBonnard requested a review from a team as a code owner March 6, 2020 13:22
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 6, 2020
@LouiseBonnard LouiseBonnard linked an issue Mar 6, 2020 that may be closed by this pull request
Space before some Spain States #18021
Closed
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Mar 6, 2020
@matks
Copy link
Contributor

matks commented Mar 6, 2020

I dont think QA will know what to test 🤔

@PierreRambaud PierreRambaud removed the Waiting for QA Status: action required, waiting for test feedback label Mar 6, 2020
@PierreRambaud PierreRambaud merged commit 56458d1 into PrestaShop:develop Mar 6, 2020
@PierreRambaud
Copy link
Contributor

@matks You're right 😅
Thanks @LouiseBonnard

@PierreRambaud PierreRambaud added this to the 1.7.8.0 milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Space before some Spain States
5 participants
@LouiseBonnard @matks @PierreRambaud @NeOMakinG @prestonBot