Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO : Correct phpDoc #18182

Merged
merged 2 commits into from Mar 19, 2020
Merged

CO : Correct phpDoc #18182

merged 2 commits into from Mar 19, 2020

Conversation

djbuch
Copy link
Contributor

@djbuch djbuch commented Mar 17, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Simply correct phpDoc and ensure the return value is an int.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

This change is Reviewable

@djbuch
Correct phpDoc
8b7f920 
Simply correct phpDoc and ensure the return value is an int.
@djbuch djbuch requested a review from a team as a code owner March 17, 2020 15:46
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 17, 2020
@djbuch djbuch changed the title Correct phpDoc CO : Correct phpDoc Mar 17, 2020
Progi1984
Progi1984 reviewed Mar 18, 2020
View reviewed changes
classes/order/Order.php Outdated Show resolved Hide resolved
PierreRambaud
PierreRambaud previously requested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP Cs fixer must be ran

@djbuch @Progi1984
Update classes/order/Order.php
7511d00 
Co-Authored-By: Progi1984 <progi1984@gmail.com>
@matks matks dismissed PierreRambaud’s stale review March 19, 2020 10:47

Feedback adressed

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Mar 19, 2020
@Progi1984
Copy link
Contributor

Only PHPDoc. No need QA.

@Progi1984 Progi1984 merged commit a830947 into PrestaShop:develop Mar 19, 2020
@matks
Copy link
Contributor

matks commented Mar 19, 2020

Only PHPDoc. No need QA.

Plus a type casting 😄this could break some bad code.
However I checked for this function usage in standard prestashop install and found only usages into "Search (customers) page" and "GDPR Customer Search page".

@Progi1984
Copy link
Contributor

Fail of my part :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

@PierreRambaud PierreRambaud Awaiting requested review from PierreRambaud

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@djbuch @Progi1984 @matks @PierreRambaud @prestonBot