Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests - Test minimum purchase total required in order to validate the order #18290

Merged
merged 4 commits into from Mar 27, 2020
Merged

Functional tests - Test minimum purchase total required in order to validate the order #18290

merged 4 commits into from Mar 27, 2020

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Mar 24, 2020 •
edited by eternoendless

Questions Answers
Branch? 1.7.7.x
Description? Test minimum purchase total required in order to validate the order
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? TEST_PATH="functional/BO/13_shopParameters/02_orderSettings/01_orderSettings/general/03_minimumPurchaseTotalRequired.js" URL_FO=yourShopURL npm run specific-test

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner March 24, 2020 14:02
@prestonBot prestonBot added 1.7.7.x Branch Refactoring Type: Refactoring Waiting for wording Status: action required, waiting for wording labels Mar 24, 2020
@nesrineabdmouleh nesrineabdmouleh changed the base branch from develop to 1.7.7.x March 24, 2020 14:03
@nesrineabdmouleh nesrineabdmouleh added TE Category: Tests and removed Waiting for wording Status: action required, waiting for wording labels Mar 24, 2020
@nesrineabdmouleh nesrineabdmouleh added this to the 1.7.7.0 milestone Mar 24, 2020
@nesrineabdmouleh nesrineabdmouleh added the WIP Status: Work In Progress label Mar 24, 2020
@nesrineabdmouleh nesrineabdmouleh removed the WIP Status: Work In Progress label Mar 24, 2020
NeOMakinG
NeOMakinG previously approved these changes Mar 24, 2020
View reviewed changes
@NeOMakinG
Copy link

Travis is red @nesrineabdmouleh

SimonGrn
SimonGrn reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@SimonGrn SimonGrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nesrineabdmouleh

..._shopParameters/02_orderSettings/01_orderSettings/general/03_minimumPurchaseTotalRequired.js Outdated
let page;
const newPurchaseTotalRequired = 100;
const defaultPurchaseTotalRequired = 0;
const alertMessage = 'A minimum shopping cart total of €100.00 (tax excl.) is required to validate your order.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const alertMessage = 'A minimum shopping cart total of €100.00 (tax excl.) is required to validate your order.';
const alertMessage = `A minimum shopping cart total of €${newPurchaseTotalRequired}.00 (tax excl.) is required to validate your order.`;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could even format it to take decimals into account ? Just a suggestion

@SimonGrn SimonGrn merged commit 9fee052 into PrestaShop:1.7.7.x Mar 27, 2020
@nesrineabdmouleh nesrineabdmouleh deleted the functionalMinimumPurchaseTotalRequired branch November 23, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonGrn SimonGrn SimonGrn left review comments

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
1.7.7.x Branch Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nesrineabdmouleh @NeOMakinG @PierreRambaud @SimonGrn @prestonBot