Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid row delete confirmation modal - Catalog > Brands > Addresses #18324

Merged
merged 2 commits into from Apr 3, 2020
Merged

Grid row delete confirmation modal - Catalog > Brands > Addresses #18324

merged 2 commits into from Apr 3, 2020

Conversation

sowbiba
Copy link
Contributor

@sowbiba sowbiba commented Mar 26, 2020 •
edited

Questions Answers
Branch? develop
Description? Add a confirmation modal when deleting a row from a grid.
Catalog > Brands > Adrdresses
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Partially Fixes #17847
How to test? Go to Catalog > Brands > Adrdresses in the BO, Try to delete a row, you will have a bootstrap modal to confirm deletion

This change is Reviewable

@sowbiba sowbiba requested a review from a team as a code owner March 26, 2020 12:56
@sowbiba sowbiba self-assigned this Mar 26, 2020
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 26, 2020
@sowbiba sowbiba changed the title #17082 : Grid row delete confirmation modal - Catalog > Brands > Add… #17847 : Grid row delete confirmation modal - Catalog > Brands > Add… Mar 26, 2020
@PierreRambaud PierreRambaud changed the title #17847 : Grid row delete confirmation modal - Catalog > Brands > Add… Grid row delete confirmation modal - Catalog > Brands > Addresses Mar 26, 2020
@matks matks added the migration symfony migration project label Mar 26, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Mar 31, 2020
Progi1984
Progi1984 previously approved these changes Mar 31, 2020
View reviewed changes
jolelievre
jolelievre previously approved these changes Apr 1, 2020
View reviewed changes
@jolelievre jolelievre added the Waiting for QA Status: action required, waiting for test feedback label Apr 1, 2020
@sowbiba sowbiba dismissed stale reviews from jolelievre and Progi1984 via 710bfa0 April 1, 2020 16:42
@sowbiba sowbiba force-pushed the 17082-row-confirm-modal-catalog-brands-addresses branch from daab21a to 710bfa0 Compare April 1, 2020 16:42
@SD1982 SD1982 added Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 2, 2020
@Progi1984 Progi1984 added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for dev Status: action required, waiting for tech feedback labels Apr 2, 2020
@SD1982 SD1982 self-assigned this Apr 3, 2020
@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 3, 2020
@SD1982
Copy link
Contributor

SD1982 commented Apr 3, 2020

The delete confirmation modal is correctly added by this PR . Thanks @sowbiba

@jolelievre jolelievre merged commit c14db43 into PrestaShop:develop Apr 3, 2020
@jolelievre
Copy link
Contributor

Thanks @sowbiba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees

@sowbiba sowbiba

@SD1982 SD1982

Labels
develop Branch Improvement Type: Improvement migration symfony migration project QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Add a modal to confirm or cancel delete action for one row [1/1]
6 participants
@sowbiba @SD1982 @jolelievre @Progi1984 @matks @prestonBot