Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor code issues #18425

Merged
merged 3 commits into from Apr 14, 2020
Merged

Fix minor code issues #18425

merged 3 commits into from Apr 14, 2020

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented Apr 2, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? This change fixes minor code issues I found while working on another bug.
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? I do not really know 🤔

This change is Reviewable

@PululuK PululuK requested a review from a team as a code owner April 2, 2020 07:31
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Apr 2, 2020
@matks
Copy link
Contributor

matks commented Apr 6, 2020 •
edited by PierreRambaud

| How to test? | I do not really know 🤔

@PululuK no worries, this PR does not need QA 👍

@PierreRambaud PierreRambaud added this to the 1.7.8.0 milestone Apr 14, 2020
@PierreRambaud PierreRambaud merged commit 075f1fc into PrestaShop:develop Apr 14, 2020
@PierreRambaud
Copy link
Contributor

Thanks @PululuK

@PululuK PululuK deleted the patch-5 branch April 14, 2020 12:24
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.8.0 Apr 14, 2020
@khouloudbelguith khouloudbelguith mentioned this pull request Apr 14, 2020
Closed
@PululuK PululuK mentioned this pull request Apr 14, 2020
Merged
@Progi1984 Progi1984 changed the title Fix minor code issues Fix minor code issues Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
develop Branch Refactoring Type: Refactoring
Projects
No open projects
PrestaShop 1.7.8.0
  
Done
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PululuK @matks @PierreRambaud @Progi1984 @prestonBot