Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the thread refers to a product, the generated link are wrong #19191

Merged
merged 5 commits into from May 19, 2020
Merged

When the thread refers to a product, the generated link are wrong #19191

merged 5 commits into from May 19, 2020

Conversation

runningz
Copy link
Contributor

@runningz runningz commented May 18, 2020 •
edited

Questions Answers
Branch? develop
Description? In customer service, when the thread refers to a product, the genereted link are wrong. I fix this for PrestaShop 1.7.6.5
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #19192
How to test? If you add a question from Order History about a purchased product, the product link added to customer service message are wrong.

This change is Reviewable

@runningz
Fix product link
b27a4d7 
When the thread refers to a product, the genereted link are wrong. I fix this.
@runningz
Fix product link
e6be3ae 
When the thread refers to a product, the genereted link are wrong. I fix this.
@runningz
Merge branch 'develop' of https://github.com/runningz/PrestaShop into…
b517b43 
… develop
@runningz
Revert "Fix product link"
d0fdd25 
This reverts commit b27a4d7.
@runningz
Fix product link
36cb245
@runningz runningz requested a review from a team as a code owner May 18, 2020 15:48
@prestonBot prestonBot added develop Branch Bug Type: Bug labels May 18, 2020
@Progi1984 Progi1984 changed the title When the thread refers to a product, the generated link are wrong. I fix this. When the thread refers to a product, the generated link are wrong May 18, 2020
@Progi1984
Copy link
Contributor

@runningz Thank you for your contribution. 🤗

Could you explain in an issue your initial bug for this PR (or may be link to an issue) ?
Could you give us a scenario which permits to test the bug before and after this PR ?

Thanks 👍

@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label May 18, 2020
@runningz
Copy link
Contributor Author

runningz commented May 18, 2020 via email

@runningz runningz mentioned this pull request May 18, 2020
Closed
@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label May 19, 2020
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label May 19, 2020
@SD1982
Copy link
Contributor

SD1982 commented May 19, 2020

LGTM Thanks @runningz !

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 19, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone May 19, 2020
@Progi1984 Progi1984 merged commit 1f890ec into PrestaShop:develop May 19, 2020
@Progi1984
Copy link
Contributor

Thanks @runningz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Product link on customer thread don't link properlly
6 participants
@runningz @Progi1984 @SD1982 @PierreRambaud @matks @prestonBot