Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix catalog price rule - Currency sort and filter not working & save button design - Backports of #19020 and #19021 for 1.7.7.x #19205

Merged
merged 3 commits into from May 19, 2020
Merged

Fix catalog price rule - Currency sort and filter not working & save button design - Backports of #19020 and #19021 for 1.7.7.x #19205

merged 3 commits into from May 19, 2020

Conversation

matks
Copy link
Contributor

@matks matks commented May 19, 2020 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.7.x
Description? Backport 2 bugfixes from develop to 1.7.7.x
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #19014 and #19005 for 1.7.7.x
How to test? See the 2 tickets

This change is Reviewable

@matks matks requested a review from a team as a code owner May 19, 2020 12:14
@prestonBot prestonBot added 1.7.7.x Branch Bug Type: Bug Waiting for wording Status: action required, waiting for wording labels May 19, 2020
@matks
Copy link
Contributor Author

matks commented May 19, 2020

@PululuK I backport your very nice work in #19021 and #19020 from develop to 1.7.7.x so 1.7.7.0 will benefit from these bug fixes.

@matks matks removed the Waiting for wording Status: action required, waiting for wording label May 19, 2020
@PululuK
Copy link
Member

PululuK commented May 19, 2020

@PululuK I backport your very nice work in #19021 and #19020 from develop to 1.7.7.x so 1.7.7.0 will benefit from these bug fixes.

@matks sincerely I still don't know in which branch I have to do my PRs ... Very sorry and thank you man !

@PierreRambaud
Copy link
Contributor

@PululuK Don't be sorry! You do more than you think for this project 😉

@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label May 19, 2020
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone May 19, 2020
@Progi1984 Progi1984 added this to To be tested in PrestaShop 1.7.7.3 May 19, 2020
@SD1982 SD1982 self-assigned this May 19, 2020
@SD1982
Copy link
Contributor

SD1982 commented May 19, 2020

LGTM Thanks @matks and @PululuK !

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 19, 2020
@SD1982 SD1982 moved this from To be tested to To be merged in PrestaShop 1.7.7.3 May 19, 2020
@matks matks merged commit 410593d into PrestaShop:1.7.7.x May 19, 2020
@matks matks deleted the backport-1 branch May 19, 2020 14:32
@Progi1984 Progi1984 moved this from To be merged to Done in PrestaShop 1.7.7.3 May 19, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label May 19, 2020
@matks
Copy link
Contributor Author

matks commented May 19, 2020

@PululuK I backport your very nice work in #19021 and #19020 from develop to 1.7.7.x so 1.7.7.0 will benefit from these bug fixes.

@matks sincerely I still don't know in which branch I have to do my PRs ... Very sorry and thank you man !

This is not always easy to find. That is why I did not want to bother you. You did the bugfix, I did the backport, and everything's good now 😊

@eternoendless eternoendless changed the title Backport bugfixes 19020 and 19021 for 1.7.7.x Fix catalog price rule - Currency sort and filter not working & save button design - Backports of #19020 and #19021 for 1.7.7.x Jun 15, 2020
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees

@SD1982 SD1982

Labels
1.7.7.x Branch Bug Type: Bug Fixed Resolution: issue closed because fixed QA ✔️ Status: check done, code approved Waiting for wording Status: action required, waiting for wording
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matks @PululuK @PierreRambaud @SD1982 @Progi1984 @prestonBot