Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swahili language #19282

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Add Swahili language #19282

merged 2 commits into from
Jun 4, 2020

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented May 22, 2020

Questions Answers
Branch? develop
Description? Add the support for Swahili language
Type? improvement
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #19193
How to test? TEST 1 :
1. BO > International > Localization
2. Add Kenya localization pack
3. 🎉 The Swahili has been installed 🎉
TEST 2 :
1. BO > International > Localization
2. Add Tanzania localization pack
3. 🎉 The Swahili has been installed 🎉

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner May 22, 2020 14:23
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels May 22, 2020
@Progi1984 Progi1984 added the LO Category: Localization label May 22, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone May 22, 2020
LouiseBonnard
LouiseBonnard previously approved these changes May 22, 2020
PierreRambaud
PierreRambaud previously approved these changes May 26, 2020
atomiix
atomiix previously approved these changes May 26, 2020
@atomiix atomiix added the Waiting for QA Status: action required, waiting for test feedback label May 26, 2020
@SD1982 SD1982 self-assigned this May 27, 2020
@SD1982
Copy link
Contributor

SD1982 commented May 27, 2020

Hi @Progi1984 The Swahili language is correctly added with Tanzania localization pack but not with Kenia localization pack ( see screen-record )
https://drive.google.com/file/d/1ISdTioELouXl1YfLVwrLiSfVzJV97dd4/view?usp=sharing

@SD1982 SD1982 added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels May 27, 2020
@Progi1984 Progi1984 added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels Jun 1, 2020
@Progi1984
Copy link
Contributor Author

@SD1982 Found the problem. The API wasn't up to date (http://api.prestashop.com/localization/17/ke.xml). So you can check it.

@SD1982
Copy link
Contributor

SD1982 commented Jun 4, 2020

Hi @Progi1984 It's ok now the swahili language is added with both localization pack ( Tanzania and Kenya . Thanks !

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 4, 2020
@Progi1984 Progi1984 merged commit 6d73ebe into PrestaShop:develop Jun 4, 2020
@Progi1984 Progi1984 deleted the issue19193 branch June 4, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement LO Category: Localization QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swahili language is not available in the back office
9 participants