Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all_languages.json #19564

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Update all_languages.json #19564

merged 1 commit into from
Jun 10, 2020

Conversation

juraj1000
Copy link
Contributor

@juraj1000 juraj1000 commented Jun 4, 2020 •
edited by Progi1984

Questions Answers
Branch? develop
Description? Changed date formats in content of localization pack for languages SK and CZ
Type? bug fix
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #19561
How to test? open BO > import localization pack for countries SK and CZ > select language SK or CZ in user profile > display in BO list of orders > check if there is used the new date format for column Date (e.g.: 25.05.2020 13:44:27) > open invoice for any order > check if there is used the new date format for date fields (e.g.: 25.05.2020)

This change is Reviewable

@juraj1000 juraj1000 requested a review from a team as a code owner June 4, 2020 11:48
@prestonBot
Copy link
Collaborator

Hello @juraj1000!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added Bug Type: Bug develop Branch labels Jun 4, 2020
@Progi1984 Progi1984 added the Waiting for wording Status: action required, waiting for wording label Jun 9, 2020
@Progi1984 Progi1984 added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for wording Status: action required, waiting for wording labels Jun 9, 2020
@SD1982
Copy link
Contributor

SD1982 commented Jun 10, 2020

LGTM the date format is correctly displayed for CZ and SK . Thanks @juraj1000 !

@SD1982 SD1982 self-assigned this Jun 10, 2020
@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 10, 2020
@Progi1984 Progi1984 merged commit 33094dd into PrestaShop:develop Jun 10, 2020
@Progi1984
Copy link
Contributor

Thanks @juraj1000 & @SD1982

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@atomiix atomiix atomiix approved these changes

@LouiseBonnard LouiseBonnard LouiseBonnard approved these changes

@Junebyun Junebyun Awaiting requested review from Junebyun

Assignees

@SD1982 SD1982

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Incorrect content of localization pack for country Slovakia
6 participants
@juraj1000 @prestonBot @SD1982 @Progi1984 @atomiix @LouiseBonnard