Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conversion rates from localization packs #19568

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Remove conversion rates from localization packs #19568

merged 1 commit into from
Jun 17, 2020

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Jun 4, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Remove conversion rates from localization packs
Type? improvement
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16656
How to test? Install must be OK.

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner June 4, 2020 12:51
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jun 4, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jun 4, 2020
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jun 5, 2020
@Progi1984 Progi1984 mentioned this pull request Jun 9, 2020
Merged
@SD1982 SD1982 self-assigned this Jun 17, 2020
@SD1982
Copy link
Contributor

SD1982 commented Jun 17, 2020

LGTM Thanks @Progi1984 !

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 17, 2020
@Progi1984 Progi1984 merged commit 0ffc740 into PrestaShop:develop Jun 17, 2020
@Progi1984
Copy link
Contributor Author

Thanks @SD1982

@Progi1984 Progi1984 deleted the issue16656 branch June 17, 2020 12:10
@LouiseBonnard LouiseBonnard mentioned this pull request Sep 23, 2020
Open
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@SD1982 SD1982

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Remove conversion rates from localization packs
5 participants
@Progi1984 @SD1982 @PierreRambaud @matthieu-rolland @prestonBot