Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified translation for easy changing the merchants number #19819

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Modified translation for easy changing the merchants number #19819

merged 1 commit into from
Jun 18, 2020

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Jun 17, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Modified translation for easy changing the merchants number
Type? improvement
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14410
How to test? Good question. Just change a translation.

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner June 17, 2020 12:27
@prestonBot prestonBot added develop Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording labels Jun 17, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jun 17, 2020
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jun 17, 2020
@Junebyun Junebyun added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Jun 17, 2020
@SD1982
Copy link
Contributor

SD1982 commented Jun 18, 2020

LGTM Thanks @Progi1984 !!

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 18, 2020
@Progi1984 Progi1984 merged commit 038e02f into PrestaShop:develop Jun 18, 2020
@Progi1984
Copy link
Contributor Author

Thanks @SD1982

@Progi1984 Progi1984 deleted the issue14410 branch June 18, 2020 08:40
@atomiix atomiix mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@LouiseBonnard LouiseBonnard LouiseBonnard approved these changes

@Junebyun Junebyun Junebyun approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Bad number of merchants in the installer
7 participants
@Progi1984 @SD1982 @PierreRambaud @NeOMakinG @LouiseBonnard @Junebyun @prestonBot