Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests - Add ids to forms in payment preferences page #19835

Merged
merged 2 commits into from Jun 18, 2020
Merged

Functional tests - Add ids to forms in payment preferences page #19835

merged 2 commits into from Jun 18, 2020

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented Jun 18, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Add ids to payment preferences forms save buttons
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? No tests needed

This change is Reviewable

@boubkerbribri boubkerbribri added the TE Category: Tests label Jun 18, 2020
@boubkerbribri boubkerbribri added this to the 1.7.8.0 milestone Jun 18, 2020
@boubkerbribri boubkerbribri requested a review from a team as a code owner June 18, 2020 09:28
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Jun 18, 2020
@boubkerbribri boubkerbribri mentioned this pull request Jun 18, 2020
Closed
NeOMakinG
NeOMakinG previously approved these changes Jun 18, 2020
View reviewed changes
PierreRambaud
PierreRambaud previously approved these changes Jun 18, 2020
View reviewed changes
@SimonGrn SimonGrn merged commit ca4c52e into PrestaShop:develop Jun 18, 2020
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.8.0 Jun 19, 2020
@boubkerbribri boubkerbribri deleted the payment-preferences-forms-id branch July 16, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@SimonGrn SimonGrn SimonGrn approved these changes

@NeOMakinG NeOMakinG NeOMakinG left review comments

Assignees
No one assigned
Labels
develop Branch Refactoring Type: Refactoring TE Category: Tests
Projects
No open projects
PrestaShop 1.7.8.0
  
Done
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@boubkerbribri @PierreRambaud @NeOMakinG @SimonGrn @prestonBot