Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modal actions to attribute and attribute actions #19838

Merged
merged 8 commits into from Jul 20, 2020
Merged

Add modal actions to attribute and attribute actions #19838

merged 8 commits into from Jul 20, 2020

Conversation

JevgenijVisockij
Copy link
Contributor

@JevgenijVisockij JevgenijVisockij commented Jun 18, 2020 •
edited by Progi1984

Questions Answers
Branch? develop
Description? Add modal actions to attribute and attribute actions
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10511.
How to test? Attributes and attribute group deletion (bulk and single) should have modals

This change is Reviewable

@JevgenijVisockij JevgenijVisockij requested a review from a team as a code owner June 18, 2020 09:50
@prestonBot prestonBot added Refactoring Type: Refactoring Waiting for wording Status: action required, waiting for wording labels Jun 18, 2020
@JevgenijVisockij JevgenijVisockij changed the title Feature/attribute group actions Feature/attribute group and attribute modals Jun 18, 2020
@Junebyun Junebyun added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Jun 18, 2020
@prestonBot prestonBot added develop Branch Waiting for wording Status: action required, waiting for wording labels Jun 18, 2020
@Junebyun Junebyun removed the Waiting for wording Status: action required, waiting for wording label Jun 19, 2020
matks
matks previously approved these changes Jun 25, 2020
View reviewed changes
PierreRambaud
PierreRambaud previously approved these changes Jun 25, 2020
View reviewed changes
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jun 25, 2020
@Progi1984 Progi1984 changed the title Feature/attribute group and attribute modals Add modal actions to attribute and attribute actions Jul 1, 2020
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Jul 1, 2020
@Junebyun Junebyun removed the Waiting for wording Status: action required, waiting for wording label Jul 2, 2020
@khouloudbelguith khouloudbelguith self-assigned this Jul 10, 2020
@khouloudbelguith
Copy link
Contributor

Hi @JevgenijVisockij,

The Modal is well displayed.
When I try to delete an item => an exception is displayed
image
https://drive.google.com/file/d/11S8Z4l83Vri-m2pGLB34Q8fDFQw8fGwk/view?usp=sharing

Thanks!

@khouloudbelguith khouloudbelguith added Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 10, 2020
@JevgenijVisockij
Copy link
Contributor Author

Hi @JevgenijVisockij,

The Modal is well displayed.
When I try to delete an item => an exception is displayed
image
https://drive.google.com/file/d/11S8Z4l83Vri-m2pGLB34Q8fDFQw8fGwk/view?usp=sharing

Thanks!

Thanks! Will check that immideatly!

@JevgenijVisockij
Copy link
Contributor Author

Solved the exception issue.

@matks matks added migration symfony migration project and removed Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Jul 17, 2020
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jul 17, 2020
@khouloudbelguith
Copy link
Contributor

Hi @JevgenijVisockij,

It is ok ✔️
https://drive.google.com/file/d/1WUo4CnkxxRfmjjCh5NVv0Ug2mf1H4kZM/view?usp=sharing

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 20, 2020
@Progi1984 Progi1984 merged commit 7436939 into PrestaShop:develop Jul 20, 2020
@Progi1984
Copy link
Contributor

Thanks @JevgenijVisockij & @khouloudbelguith

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PululuK PululuK PululuK requested changes

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matks matks matks approved these changes

Assignees

@khouloudbelguith khouloudbelguith

Labels
develop Branch migration symfony migration project QA ✔️ Status: check done, code approved Refactoring Type: Refactoring Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Migrate "Catalog > Attributes & Features > Attributes" listing page
8 participants
@JevgenijVisockij @khouloudbelguith @Progi1984 @PierreRambaud @matks @PululuK @prestonBot @Junebyun