Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trace information to Command/Query debugger #19854

Merged
merged 3 commits into from Jun 19, 2020
Merged

Add trace information to Command/Query debugger #19854

merged 3 commits into from Jun 19, 2020

Conversation

eternoendless
Copy link
Member

@eternoendless eternoendless commented Jun 18, 2020 •
edited

Questions Answers
Branch? 1.7.7.x
Description? This change tracks where Commands and Queries were fired from and shows it in the profiler.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? See below

What it looks like

Screenshot

How to test

  1. Open any page that uses Commands or Queries in dev mode
  2. Open the SF profiler
  3. Go to the Commands and Queries section
  4. See where the Commands and Queries were fired from.

This change is Reviewable

@eternoendless eternoendless added the Developer Feature Developer-oriented feature label Jun 18, 2020
@eternoendless eternoendless requested a review from a team as a code owner June 18, 2020 14:30
@prestonBot prestonBot added 1.7.7.x Branch Improvement Type: Improvement labels Jun 18, 2020
@Progi1984
Copy link
Contributor

If it's a improvemnt, it should not target the develop branch ?

Progi1984
Progi1984 previously approved these changes Jun 19, 2020
View reviewed changes
@eternoendless
Copy link
Member Author

If it's an improvement, it should not target the develop branch ?

Yes but this improves a new developer feature from 1.7.7 (we can merge it without QA)

@PierreRambaud
Copy link
Contributor

If it's an improvement, it should not target the develop branch ?

Yes but this improves a new developer feature from 1.7.7 (we can merge it without QA)

GitHub targets the develop branch when the descript targets 1.7.7.x 🤔

@eternoendless
Copy link
Member Author

GitHub targets the develop branch when the descript targets 1.7.7.x 🤔

Ooops, let me change that real quick

@eternoendless eternoendless changed the base branch from develop to 1.7.7.x June 19, 2020 08:57
@eternoendless eternoendless dismissed Progi1984’s stale review June 19, 2020 08:57

The base branch was changed.

@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Jun 19, 2020
@SD1982 SD1982 self-assigned this Jun 19, 2020
@SD1982
Copy link
Contributor

SD1982 commented Jun 19, 2020

LGTM Thanks @eternoendless !!

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 19, 2020
@Progi1984 Progi1984 merged commit 1f47005 into PrestaShop:1.7.7.x Jun 19, 2020
@Progi1984
Copy link
Contributor

Thanks @eternoendless

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Jun 19, 2020
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.7.3 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@PierreRambaud PierreRambaud Awaiting requested review from PierreRambaud

Assignees

@SD1982 SD1982

Labels
1.7.7.x Branch Developer Feature Developer-oriented feature Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eternoendless @Progi1984 @PierreRambaud @SD1982 @matthieu-rolland @prestonBot