Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore swo temporary files in gitignore #20074

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Ignore swo temporary files in gitignore #20074

merged 1 commit into from
Jul 6, 2020

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Jul 6, 2020 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? VIM swo files are not ignored, this can lead to mistakes for vim users leading to unwanted files on the repository
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Nothing to test there, no QA needed

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from a team as a code owner July 6, 2020 14:06
@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The category should be one of: FO, BO, CO, IN, TE, WS, LO, ME, PM

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jul 6, 2020
@NeOMakinG NeOMakinG added the QA ✔️ Status: check done, code approved label Jul 6, 2020
@prestashop-issue-bot
Copy link

QA OK without required approvals !? :trollface:

PierreRambaud
PierreRambaud approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should configure your ~/.gitignore next time 😉
I never understand why a project tries to ignore something not related to the project itself.

@PierreRambaud PierreRambaud merged commit 14e5d95 into PrestaShop:develop Jul 6, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jul 7, 2020
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.8.0 Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
No open projects
PrestaShop 1.7.8.0
  
Done
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NeOMakinG @prestonBot @PierreRambaud @matthieu-rolland @Progi1984