Correctly uncheck previous default combination #20126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progi1984
approved these changes
Jul 10, 2020
PierreRambaud
approved these changes
Jul 10, 2020
PierreRambaud
added
the
Waiting for QA
|
Hi @Amazzing, It is ok ✔️ Thanks! |
khouloudbelguith
added
QA ✔️
|
Thanks @Amazzing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeAttr('checked')doesn't actually uncheck the checkbox, so if you change default combination multiple times, then many inputs$('.attribute_default_checkbox')will remain checked, and only the last in DOM tree will be saved as default combination.After this don't reload page, and set 3rd combination as default and save product again. There will be Settings updated notification but default combination will not be updated correctly, you can check that after reloading page, or checking database table.
This change is