Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search combination by ean #20453

Merged
merged 1 commit into from Aug 18, 2020
Merged

Search combination by ean #20453

merged 1 commit into from Aug 18, 2020

Conversation

camlafit
Copy link
Contributor

@camlafit camlafit commented Aug 4, 2020 •
edited by PierreRambaud

  • Mainly, it's backport from product class
  • By default we can't find combination by their ean identifier
Questions Answers
Branch? develop
Description? Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? not relevant
How to test? not relevant

This change is Reviewable

@camlafit
Search combination by ean
115f9a8 
* Mainly, it's backport from product class
* By default we can't find combination by their ean identifier
@camlafit camlafit requested a review from a team as a code owner August 4, 2020 14:12
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Aug 4, 2020
@Robin-Fischer-PS Robin-Fischer-PS added the QA ✔️ Status: check done, code approved label Aug 18, 2020
@Robin-Fischer-PS
Copy link
Contributor

Tested by @PierreRambaud under my supervision 😛

@PierreRambaud PierreRambaud added this to the 1.7.8.0 milestone Aug 18, 2020
@PierreRambaud PierreRambaud merged commit 7b820eb into PrestaShop:develop Aug 18, 2020
@PierreRambaud
Copy link
Contributor

Thanks @camlafit

@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.8.0 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
No open projects
PrestaShop 1.7.8.0
  
Done
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@camlafit @Robin-Fischer-PS @PierreRambaud @Progi1984 @matks @prestonBot