Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo Error in AdminOutstandingController.php #20475

Merged
merged 4 commits into from Aug 7, 2020
Merged

Typo Error in AdminOutstandingController.php #20475

merged 4 commits into from Aug 7, 2020

Conversation

Amit-Kumar-Tiwari-Webkul
Copy link
Contributor

@Amit-Kumar-Tiwari-Webkul Amit-Kumar-Tiwari-Webkul commented Aug 5, 2020 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Typo Error
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? I think, there is no need to test it.

This change is Reviewable

@Amit-Kumar-Tiwari-Webkul Amit-Kumar-Tiwari-Webkul requested a review from a team as a code owner August 5, 2020 19:12
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Aug 5, 2020
@Amit-Kumar-Tiwari-Webkul Amit-Kumar-Tiwari-Webkul changed the title Amit kumar tiwari webkul typo Typo Error in AdminOutstandingController.php Aug 5, 2020
matks
matks approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed there is no need to test it :) thanks, nice catch !

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Aug 7, 2020
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.8.0 Aug 7, 2020
@Progi1984 Progi1984 merged commit 04ef101 into PrestaShop:develop Aug 7, 2020
@Progi1984
Copy link
Contributor

Thanks @Amit-Kumar-Tiwari-Webkul

@Amit-Kumar-Tiwari-Webkul Amit-Kumar-Tiwari-Webkul deleted the Amit-Kumar-Tiwari-Webkul-typo branch August 7, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
No open projects
PrestaShop 1.7.8.0
  
Done
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Amit-Kumar-Tiwari-Webkul @Progi1984 @matks @prestonBot