Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cumulative percentage behat test #20758

Merged
merged 1 commit into from Aug 27, 2020
Merged

Fix cumulative percentage behat test #20758

merged 1 commit into from Aug 27, 2020

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Aug 27, 2020 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.7.x
Description? The test of cumulative percentage reductions's contextual values was badly tested and would pass with wrong values
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? No manual test: behat test must be green

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from a team as a code owner August 27, 2020 14:10
@prestonBot prestonBot added 1.7.7.x Branch Bug Type: Bug labels Aug 27, 2020
@PrestaShop PrestaShop deleted a comment from prestonBot Aug 27, 2020
@jolelievre jolelievre merged commit ed26186 into PrestaShop:1.7.7.x Aug 27, 2020
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Sep 2, 2020
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.7.3 Sep 2, 2020
@Progi1984 Progi1984 changed the title fix cumulative percentage behat test Fix cumulative percentage behat test Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees
No one assigned
Labels
1.7.7.x Branch Bug Type: Bug
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthieu-rolland @atomiix @jolelievre @Progi1984 @prestonBot