New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed PHPDoc of Tax's getProductTaxRate to more accurate. #21042
Conversation
The method `getProductTaxRate` returns a `Tax` object according to the PHPDoc. I have changed this PHPDoc to return the type `float`.
Hello @stijnstroeve! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
Co-authored-by: Progi1984 <progi1984@gmail.com>
No need QA : it's PHPDoc. Thanks @stijnstroeve |
Tax
class the methodgetProductTaxRate
returns aTax
object according to the PHPDoc. I have changed this PHPDoc to return the typefloat
.This change is