Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed PHPDoc of Tax's getProductTaxRate to more accurate. #21042

Merged
merged 2 commits into from Sep 23, 2020

Conversation

stijnstroeve
Copy link
Contributor

@stijnstroeve stijnstroeve commented Sep 17, 2020

Questions Answers
Branch? develop
Description? In the current version of the Tax class the method getProductTaxRate returns a Tax object according to the PHPDoc. I have changed this PHPDoc to return the type float.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? It does not really need testing because this only affects a PHPDoc.

This change is Reviewable

The method `getProductTaxRate` returns a `Tax` object according to the PHPDoc. I have changed this PHPDoc to return the type `float`.
@stijnstroeve stijnstroeve requested a review from a team as a code owner September 17, 2020 13:58
@prestonBot
Copy link
Collaborator

Hello @stijnstroeve!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Bug Type: Bug label Sep 17, 2020
@stijnstroeve stijnstroeve changed the title Update Tax.php Changed PHPDoc of Tax's getProductTaxRate to more accurate. Sep 17, 2020
@prestonBot prestonBot added the develop Branch label Sep 18, 2020
PierreRambaud
PierreRambaud previously approved these changes Sep 18, 2020
classes/tax/Tax.php Outdated Show resolved Hide resolved
@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Sep 21, 2020
Co-authored-by: Progi1984 <progi1984@gmail.com>
@PierreRambaud PierreRambaud removed the Waiting for author Status: action required, waiting for author feedback label Sep 22, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Sep 23, 2020
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.8.0 Sep 23, 2020
@Progi1984 Progi1984 merged commit 7b69800 into PrestaShop:develop Sep 23, 2020
@Progi1984
Copy link
Contributor

No need QA : it's PHPDoc.

Thanks @stijnstroeve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants