Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modules for 177 #21178

Merged
merged 1 commit into from Sep 28, 2020
Merged

Update modules for 177 #21178

merged 1 commit into from Sep 28, 2020

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Sep 27, 2020 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.7.x
Description? Update modules for 177
Type? improvement
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? Not sure it is required to test it, the latest versions were already pushed by the API This simply include them with the default dependencies Maybe just check that the install process is ok (Already tested CLI install everything seems fine)

This change is Reviewable

@jolelievre jolelievre requested a review from a team as a code owner September 27, 2020 14:21
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added 1.7.7.x Branch Improvement Type: Improvement labels Sep 27, 2020
@jolelievre jolelievre added this to To be reviewed in PrestaShop 1.7.7.3 Sep 27, 2020
@jolelievre jolelievre added this to the 1.7.7.0 milestone Sep 27, 2020
@jolelievre jolelievre added the Waiting for dev Status: action required, waiting for tech feedback label Sep 27, 2020
@Progi1984 Progi1984 merged commit 7dec0ed into PrestaShop:1.7.7.x Sep 28, 2020
@Progi1984
Copy link
Contributor

Thanks @sarahdib for tests :)

@Progi1984 Progi1984 removed the Waiting for dev Status: action required, waiting for tech feedback label Sep 28, 2020
@Progi1984 Progi1984 moved this from To be reviewed to Done in PrestaShop 1.7.7.3 Sep 28, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

@PululuK PululuK PululuK approved these changes

Assignees
No one assigned
Labels
1.7.7.x Branch Fixed Resolution: issue closed because fixed Improvement Type: Improvement
Projects
No open projects
PrestaShop 1.7.7.3
  
Done
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jolelievre @prestonBot @Progi1984 @matks @PululuK