Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ProductCategoryUpdater and use it in handlers. Remove AbstractProductCategoryHandler #21321

Merged
merged 7 commits into from Nov 3, 2020
Merged

Introduce ProductCategoryUpdater and use it in handlers. Remove AbstractProductCategoryHandler #21321

merged 7 commits into from Nov 3, 2020

Conversation

zuk3975
Copy link
Contributor

@zuk3975 zuk3975 commented Oct 6, 2020 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Refactor handlers to use ProductCategoryUpdater and ProductRepository instead of relying on Abstract{..}Handler class. All refactored classes haven't been released yet so there is no BC breaks. There is still TODO left for multishop handling, even though legacy object model methods already has shop assiciation handled in SQL scope, there might still be some problems with that.
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? part of #19518
How to test? CI ✔️

This change is Reviewable

@zuk3975 zuk3975 requested a review from a team as a code owner October 6, 2020 12:11
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Oct 6, 2020
@Progi1984 Progi1984 linked an issue Oct 6, 2020 that may be closed by this pull request
[Basic settings tab] - Associated categories 8/14 #19518
Open
5 tasks
@matks matks added the migration symfony migration project label Oct 9, 2020
matks
matks previously approved these changes Oct 12, 2020
View reviewed changes
@matthieu-rolland
Copy link
Contributor

@zuk3975 thank you for your PR, there is a rebase / conflict resolution to be done ;)

@matks matks added the Waiting for rebase Status: action required, waiting for rebase label Oct 22, 2020
@zuk3975 zuk3975 dismissed stale reviews from matthieu-rolland and matks via 91bb90c October 26, 2020 13:38
@zuk3975 zuk3975 force-pushed the m/product/categories-updater branch 2 times, most recently from 91bb90c to b792c3f Compare October 26, 2020 13:47
@zuk3975 zuk3975 force-pushed the m/product/categories-updater branch from b792c3f to d651ad8 Compare November 3, 2020 08:43
@matks matks removed the Waiting for rebase Status: action required, waiting for rebase label Nov 3, 2020
@matks matks merged commit 809f717 into PrestaShop:develop Nov 3, 2020
@matks
Copy link
Contributor

matks commented Nov 3, 2020

Thank you @zuk3975

@matks matks deleted the m/product/categories-updater branch November 3, 2020 12:52
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@jolelievre jolelievre jolelievre approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland left review comments

Assignees
No one assigned
Labels
develop Branch migration symfony migration project Refactoring Type: Refactoring
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

[Basic settings tab] - Associated categories 8/14
6 participants
@zuk3975 @matthieu-rolland @matks @jolelievre @Progi1984 @prestonBot