Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Customer class #21691

Merged
merged 2 commits into from Nov 2, 2020
Merged

Fix typo in Customer class #21691

merged 2 commits into from Nov 2, 2020

Conversation

ksaandev
Copy link
Contributor

@ksaandev ksaandev commented Oct 30, 2020

Questions Answers
Branch? develop
Description? Fix typo in Customer class
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

This change is Reviewable

@ksaandev ksaandev requested a review from a team as a code owner October 30, 2020 13:48
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)
  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Oct 30, 2020
@PululuK
Copy link
Member

PululuK commented Oct 30, 2020

Nice @ksaandev 👍🏿

If you have the time could you take the opportunity to apply this fix here too please : https://github.com/PrestaShop/PrestaShop/blob/develop/classes/Employee.php#L98

No need to open a new PR, you can fix it here 😉

PululuK
PululuK previously approved these changes Oct 30, 2020
@ksaandev
Copy link
Contributor Author

ksaandev commented Nov 1, 2020

@PululuK done!

@Progi1984 Progi1984 added the Documentation ✔️ Developer documentation is up-to-date label Nov 2, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Nov 2, 2020
@Progi1984 Progi1984 merged commit fdf4cd4 into PrestaShop:develop Nov 2, 2020
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@Progi1984
Copy link
Contributor

Thanks @ksaandev

@matks matks added Needs documentation Needs an update of the developer documentation and removed Documentation ✔️ Developer documentation is up-to-date labels Mar 25, 2022
@kpodemski kpodemski removed the Needs documentation Needs an update of the developer documentation label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants