Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test 'Filter sort and pagination order return status' #21779

Merged
merged 7 commits into from Nov 18, 2020
Merged

Add test 'Filter sort and pagination order return status' #21779

merged 7 commits into from Nov 18, 2020

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Nov 5, 2020 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? no
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #{issue number here}.
How to test? TEST_PATH=TEST_PATH="functional/BO/13_shopParameters/02_orderSettings/02_statuses/returnStatuses/02_filterSortAndPagination" URL_FO=yourShopURL npm run specific-test

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner November 5, 2020 16:09
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Nov 5, 2020
@nesrineabdmouleh nesrineabdmouleh added the TE Category: Tests label Nov 5, 2020
@nesrineabdmouleh nesrineabdmouleh added this to the 1.7.8.0 milestone Nov 5, 2020
Progi1984
Progi1984 reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change baseContext in tests/UI/campaigns/functional/BO/13_shopParameters/02_orderSettings/02_statuses/statuses/01_CRUDOrderStatus.js

Progi1984
Progi1984 reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change baseContext in tests/UI/campaigns/functional/BO/13_shopParameters/02_orderSettings/02_statuses/statuses/01_CRUDOrderStatus.js

@SimonGrn
Copy link
Contributor

Need to change baseContext in tests/UI/campaigns/functional/BO/13_shopParameters/02_orderSettings/02_statuses/statuses/01_CRUDOrderStatus.js

Is there a reason ?

@Progi1984
Copy link
Contributor

The file has been renamed.

@nesrineabdmouleh
Copy link
Contributor Author

The file has been renamed.

I think that the name is correct, what's the problem?

@Progi1984 Progi1984 added the QA ✔️ Status: check done, code approved label Nov 18, 2020
@SimonGrn SimonGrn merged commit 4e08957 into PrestaShop:develop Nov 18, 2020
@nesrineabdmouleh nesrineabdmouleh deleted the functionalFilterSortAndPaginationOrderReturnStatus branch November 23, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@SimonGrn SimonGrn SimonGrn approved these changes

@boubkerbribri boubkerbribri Awaiting requested review from boubkerbribri

Assignees
No one assigned
Labels
develop Branch QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nesrineabdmouleh @SimonGrn @Progi1984 @boubkerbribri @prestonBot