Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix payment layout broken on small screens #22102

Merged
merged 2 commits into from Dec 1, 2020
Merged

Fix payment layout broken on small screens #22102

merged 2 commits into from Dec 1, 2020

Conversation

NeOMakinG
Copy link

Questions Answers
Branch? develop
Description? Payment window had an overflow on small screens
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13061.
How to test? See issue

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 1.7.8.0 milestone Nov 25, 2020
@NeOMakinG NeOMakinG requested a review from a team as a code owner November 25, 2020 14:45
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Nov 25, 2020
atomiix
atomiix previously approved these changes Nov 25, 2020
View reviewed changes
@atomiix
Copy link
Contributor

atomiix commented Nov 25, 2020

@NeOMakinG Don't you think we should wait for #22100 to be merged and then 1.7.7.x to develop instead of redoing the fix?

@NeOMakinG
Copy link
Author

@NeOMakinG Don't you think we should wait for #22100 to be merged and then 1.7.7.x to develop instead of redoing the fix?

Since it's not in the same file anymore (because we did split bundles), I was like "Let's add it on the new file too, so rebase errors are not coming up"

Progi1984
Progi1984 previously approved these changes Nov 26, 2020
View reviewed changes
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Nov 26, 2020
@khouloudbelguith khouloudbelguith self-assigned this Nov 27, 2020
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

I found an issue when using a mobile.
image

Thanks!

@khouloudbelguith khouloudbelguith added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 27, 2020
@NeOMakinG
Copy link
Author

Mehh

@PrestaShop/ux-team help! Should I add an overflow scroll on mobile ?

@prestascott
Copy link

@NeOMakinG Yes, we must add an horizontal scrollbar

@NeOMakinG NeOMakinG dismissed stale reviews from Progi1984 and atomiix via 9d2709c November 30, 2020 09:28
@NeOMakinG NeOMakinG removed the Waiting for author Status: action required, waiting for author feedback label Nov 30, 2020
@atomiix atomiix added the Waiting for QA Status: action required, waiting for test feedback label Nov 30, 2020
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

It is ok ✔️
https://www.awesomescreenshot.com/video/1909645?key=7f85a5b26e288288cd933b461300c4eb

Mobile => ok
https://drive.google.com/file/d/1UUV1O3hd5CCUaO9V7SzOoxkDA9nV1at6/view?usp=sharing

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 1, 2020
@Progi1984 Progi1984 merged commit 8449a18 into PrestaShop:develop Dec 1, 2020
@Progi1984
Copy link
Contributor

Thanks @NeOMakinG & @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@atomiix atomiix atomiix approved these changes

Assignees

@khouloudbelguith khouloudbelguith

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

The lines inside table > tbody payments in orders tab go out of their coantiner
6 participants
@NeOMakinG @atomiix @khouloudbelguith @prestascott @Progi1984 @prestonBot