Fix upgrade from ps < 1.7.0.0

[atomiix]

Questions	Answers
Branch?	1.7.7.x
Description?	Because the table ps_tab has been changed on 1.7.7.x, when executing the 1.7.0.0 upgrade script, tabs weren't properly updated. The other issue was that because of a previous upgrade script, the Language class had cache that wasn't up-to-date with the new database structure leading to an SQL update error. This PR fixes both bugs.
Type?	bug fix
Category?	CO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #22237 #22294
How to test?	Try to upgrade a shop from PrestaShop < 1.7.0.0 (1.6.1.24) to 1.7.7.0, the upgrade process should finish without any error.

---

This change is 

[matks]

@atomiix Could it also fix #22250 ?

[atomiix]

@matks I don't think so as #22250 happens from 1.7.6.9 while I'm doing some changes for version < 1.7.0.0

[matks]

If I understand correctly,

For PS 1.6 => PS 1.7.6 we have a different structure for tabs (between PS 1.6 and PS 1.7) and the script correctly migrates it
But for PS 1.6 => PS 1.7.7, the file structure is "immediately" migrated to 177 version so the script fails because it expects the old structure

So we have a different script for ps1.6 => ps1.7.6 and ps1.6 => ps1.7.7 ?

[atomiix]

That's the opposite, when upgrading from PS 1.6 to PS 1.7.7, the upgrade script uses core files that expect the new DB structure.

[matks]

Code seems OK for me. QA team can validate 1.6 => 1.7 upgrade and automated tests can validate the other paths

[SD1982]

Hi @atomiix The original error is not displayed but I have this error now
I don't know if it's related with your PR because I can really test without

[INTERNAL] /var/www/html/builds/1.6.1.24/app/AppKernel.php line 39 - ParseError: syntax error, unexpected ';' #0 /var/www/html/builds/1.6.1.24/modules/autoupgrade/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/var/www/html/b...') #1 [internal function]: Composer\Autoload\ClassLoader->loadClass('AppKernel') #2 /var/www/html/builds/1.6.1.24/config/autoload.php(28): spl_autoload_call('AppKernel') #3 /var/www/html/builds/1.6.1.24/modules/autoupgrade/classes/UpgradeContainer.php(545): require_once('/var/www/html/b...') #4 /var/www/html/builds/1.6.1.24/modules/autoupgrade/classes/TaskRunner/Upgrade/UpgradeDb.php(73): PrestaShop\Module\AutoUpgrade\UpgradeContainer->initPrestaShopAutoloader() #5 /var/www/html/builds/1.6.1.24/admin762k5hk9q/autoupgrade/ajax-upgradetab.php(52): PrestaShop\Module\AutoUpgrade\TaskRunner\Upgrade\UpgradeDb->init() #6 {main}

Tested on php7.1 and mysql 5.7

[SD1982]

Hi @atomiix As we have seen together there is now this error which is displayed:

SQL 1.7.7.0 1146 in UPDATE ps_admin_filterSETfilter_id = SUBSTRING(filter_id, 1, 191): Table 'prestashop-161.ps_admin_filter' doesn't exist SQL 1.7.7.0 1146 in ALTER TABLE ps_admin_filterCHANGEfilter_id filter_idVARCHAR(191) NOT NULL: Table 'prestashop-161.ps_admin_filter' doesn't exist SQL 1.7.7.0 1146 in ALTER TABLEps_admin_filterCONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci: Table 'prestashop-161.ps_admin_filter' doesn't exist SQL 1.7.7.0 1146 in ALTER TABLEps_link_blockCONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci: Table 'prestashop-161.ps_link_block' doesn't exist SQL 1.7.7.0 1146 in ALTER TABLEps_link_block_langCONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci: Table 'prestashop-161.ps_link_block_lang' doesn't exist SQL 1.7.7.0 1146 in ALTER TABLEps_link_block_shopCONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci: Table 'prestashop-161.ps_link_block_shop' doesn't exist SQL 1.7.7.0 1146 in ALTER TABLEps_module_historyCONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci: Table 'prestashop-161.ps_module_history' doesn't exist SQL 1.7.7.0 1146 in ALTER TABLEps_translation CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci: Table 'prestashop-161.ps_translation' doesn't exist

[Progi1984]

Some feedback

[jolelievre]

Not sure about the last comment so I still approve I let you judge if the modif is required or not

[SD1982]

LGTM now !! No errors displayed during the upgrade process !!
upgraded from 1.6.1.24
php 7.1
mysql 5.7
Thanks @atomiix !!

[gyan111]

When will this available on autoupgrade?

[matks]

@gyan111 This PR has been milestoned for PS 1.7.7.1 which is scheduled for mid January 2021 or late January 2021.

[mbautista]

Hello,
I try to upgrade from PS 1.6.0.11 to PS 1.7.8.5 and I have this error :

# /usr/bin/php7.1 install/upgrade/upgrade.php
PHP Warning:  Invalid argument supplied for foreach() in /***/classes/Profile.php on line 251
PHP Fatal error:  Uncaught PrestaShopObjectNotFoundException: The hook id #0 does not exist in database in /***/classes/Hook.php:242
Stack trace:
#0 /***/classes/Hook.php(677): HookCore::getNameById(0)
#1 /***/classes/module/Module.php(1029): HookCore::unregisterHook(Object(BlockSearch), 0, NULL)
#2 /***/classes/module/Module.php(733): ModuleCore->unregisterHook(0)
#3 /***/src/Adapter/Module/Module.php(269): ModuleCore->uninstall()
#4 /***/src/PrestaShopBundle/Install/Upgrade.php(565): PrestaShop\PrestaShop\Adapter\Module\Module->onUninstall()
#5 /***/src/PrestaShopBundle/Install/Upgrade.php(820): PrestaShopBundle\Install\Upgrade->disableIncompatibleModules()
#6 /***/install/upgrade/upgrade.php(93): PrestaShopBundle\Install\Upgrade->run()
#7 {main}
  thrown in /***/classes/Hook.php on line 242

Is there any solution for this ?
Thank you very much :)

EDIT : I found a simple hack : juste add the following line in classes/Hook.php before line 234 (beginning of the getNameById function) :
if ($hook_id == 0) return null;
I had another problem with the paypal module, I renamed the folder and the upgrade script could complete without any further error.