Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show help message for PageNotFound for ajax calls #22539

Merged
merged 1 commit into from Jan 6, 2021
Merged

Show help message for PageNotFound for ajax calls #22539

merged 1 commit into from Jan 6, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Dec 22, 2020 •
edited

Questions Answers
Branch? develop
Description? Show help message for PageNotFound for ajax calls instead of nothing
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #22538
How to test? See ticket. Instead of blank page, the ajax route that does not exist will return message The page you are looking for was not found. in JSON
Possible impacts? Only the ticket scope is concerned.

This change is Reviewable

@matks matks requested a review from a team as a code owner December 22, 2020 13:36
@prestonBot prestonBot added develop Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording labels Dec 22, 2020
@Julievrz Julievrz added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Dec 23, 2020
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Dec 29, 2020
@khouloudbelguith khouloudbelguith self-assigned this Jan 6, 2021
@khouloudbelguith
Copy link
Contributor

Hi @matks,

It is Ok ✔️
Without PR
image
With PR
image

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 6, 2021
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@khouloudbelguith khouloudbelguith added this to the 1.7.8.0 milestone Jan 6, 2021
@Progi1984 Progi1984 merged commit 3e4f4a9 into PrestaShop:develop Jan 6, 2021
@Progi1984
Copy link
Contributor

Thanks @matks & @khouloudbelguith

@matks matks deleted the helper-controller-not-found branch April 15, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees

@khouloudbelguith khouloudbelguith

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Return a useful message when "page not found" happens for AJAX calls
8 participants
@matks @khouloudbelguith @prestonBot @Progi1984 @PierreRambaud @matthieu-rolland @NeOMakinG @Julievrz