Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdminStats Controller use the good column for total #22585

Merged
merged 1 commit into from Jan 7, 2021
Merged

AdminStats Controller use the good column for total #22585

merged 1 commit into from Jan 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 24, 2020 •
edited by ghost

Questions Answers
Branch? develop
Description? The column product_price is the price without reduction so the stats as bad
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #22671
How to test? Check the stats follow the issue
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

This change is Reviewable

@ghost ghost self-requested a review as a code owner December 24, 2020 11:05
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Dec 24, 2020
@ghost ghost changed the title Use the good column for total AdminStats Controller use the good column for total Dec 24, 2020
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Dec 28, 2020
@matthieu-rolland matthieu-rolland added this to the 1.7.8.0 milestone Dec 28, 2020
@khouloudbelguith khouloudbelguith self-assigned this Jan 4, 2021
@khouloudbelguith
Copy link
Contributor

Hi @okom3pom,

I still have the same issue.
I attached a screen record
Untitled_ Jan 4, 2021 5_51 PM.zip

Thanks to check and feedback

@khouloudbelguith khouloudbelguith added the Waiting for author Status: action required, waiting for author feedback label Jan 4, 2021
@ghost
Copy link
Author

ghost commented Jan 5, 2021

oh it's right it's this one who fix PrestaShop/statsforecast#19

I asked @ttoine for information on the future

@ghost
Copy link
Author

ghost commented Jan 5, 2021

This PR fix the KPI here

Capture d’écran de 2021-01-05 10-20-10

I must open a new issue

@ghost
Copy link
Author

ghost commented Jan 5, 2021

I open new issue #22671 for this PR

@Progi1984 Progi1984 removed the Waiting for QA Status: action required, waiting for test feedback label Jan 5, 2021
@khouloudbelguith
Copy link
Contributor

Hi @okom3pom,

Is it ready for QA?

Thank you!

@ghost
Copy link
Author

ghost commented Jan 6, 2021

Yes

@khouloudbelguith khouloudbelguith added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels Jan 6, 2021
@khouloudbelguith
Copy link
Contributor

Hi @okom3pom,

It is ok ✔️
https://drive.google.com/file/d/1OitnBqsO5p1sso06xzrNZIjQsP5-W8t1/view?usp=sharing

Thank you!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 7, 2021
@Progi1984 Progi1984 merged commit 993bfd0 into PrestaShop:develop Jan 7, 2021
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@Progi1984
Copy link
Contributor

Thanks @okom3pom & @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@khouloudbelguith khouloudbelguith

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

AdminStats Controller KPI best category is bad
6 participants
@khouloudbelguith @prestonBot @Progi1984 @PierreRambaud @matthieu-rolland @Touxten