Remove microdata in html flow and replace by JSON-LD for classic theme #23151

fdonnet · 2021-02-05T09:27:52Z

Questions	Answers
Branch?	develop
Description?	Try to propose a solution for all the recurent issues with Google Rich Text validator. (REOPEN => I made a silly git mistake I was not able to roll back)
Type?	improvement
Category?	FO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #22867
How to test?	Fresh version of Presta, go on Goolge rich text validator, test index, category and product pages => clean
Possible impacts?	Change in classic template. Add two new files included in head.tpl

The goal of this PR is to open the discussion about the microdata management.
A lot of issues are open about this topic recently.
The proposition is to keep the meta tags in the html flow but remove the microdata information and create a specific file that centralizes all the microdata and use JSON-LD for the declaration.
inspired a lot by github =>prestarocket-agence/classic-rocket

themes/classic/templates/_partials/microdata-jsonld.tpl :

This file is included in the head.tpl.
For the moment it's not perfect but it centralizes the info for futher improvements.

It takes care of this kind of microdata

Webpage
Organization
Search link
Category pages (ListItem but that only ref the product pages no product details in the ListItem)
Products (need to be standardized)
~~Product combinations declared as an offer for the product (with stock and correct price) => great stuff ;)~~ Not implemented for standard shop (people will be able to override)
Breadcrumb

The product JSON declaration is not perfect. But like explained it's to open the discussion about the "centralization" of the concept and after that, maybe people who go deep;) will create new smarty variables that will help to enrich the microdata declaration.

~~people find comibnations (colors, flavors) too. => solve the problem when you have single cannonical url per product and your combinations will be skipped by Google bot.~~ (available in the first commit of this PR, but removed to remain standard)

Other files => remove each instance of itemprop and itemscope
Trick for pagination pages

Hope it will help...

This change is

prestonBot · 2021-02-05T09:27:55Z

Hello @fdonnet!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

boubkerbribri · 2021-02-08T10:16:58Z

Hello @fdonnet ,
I'm sorry but me and @nesrineabdmouleh can't help you fix this error because it's not related to the tests, maybe @PrestaShop/prestashop-maintainers

What I can assure you is that I checkout you PR and the error exists on php7.4

NeOMakinG · 2021-02-11T15:17:36Z

I can't get why it would fail on 7.4 and not on previous versions, this is pretty strange

NeOMakinG · 2021-02-11T15:32:07Z

Running tests again as the fail isn't from the PR

themes/classic/templates/catalog/_partials/product-prices.tpl

Progi1984

A small feedback

themes/classic/templates/catalog/_partials/product-prices.tpl

Progi1984

A last one

…de cleaning - and correct files structure)

…eep modification for SEO opti by NEOMaking

themes/classic/templates/catalog/_partials/product-cover-thumbnails.tpl

themes/classic/templates/_partials/microdata/head-jsonld.tpl

NeOMakinG

I tested with the fix:
https://search.google.com/test/rich-results?id=d-gSZPtkd3p4T5GjTKImNg

It's fine now (errors are generated because my urls aren't reachable by Google)

prestonBot · 2021-03-24T13:56:14Z

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

NeOMakinG · 2021-03-24T13:56:51Z

As it's a QA by dev, feel free to merge it when it gets 2 approves!

Good job @fdonnet

fdonnet · 2021-03-24T14:01:52Z

Thx, @NeOMakinG for the reviews, the advice and the support !

NeOMakinG · 2021-03-24T15:36:52Z

Trying to run tests again

prestonBot · 2021-03-24T16:49:40Z

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

Progi1984 · 2021-03-24T16:49:52Z

Thanks @fdonnet & @NeOMakinG for QA ;)

prestashop-issue-bot · 2021-03-24T17:30:35Z

QA OK without required approvals !?

Hlavtox · 2021-03-24T17:45:58Z

@fdonnet You're the boss!!!

fdonnet · 2021-03-24T17:48:11Z

@Hlavtox thx for your help too on polishing a lot of things ! Cool to be merged ;)

Progi1984 · 2021-03-25T08:10:24Z

@fdonnet @Hlavtox Good job guys 💪

mgielecinski · 2021-04-27T10:08:35Z

themes/classic/templates/_partials/microdata/head-jsonld.tpl

+      "url" : "{$urls.pages.index}",
+      "image": {
+        "@type": "ImageObject",
+        "url":"{$urls.shop_domain_url}{$shop.logo}"


hello, this is bad
{$urls.shop_domain_url}{$shop.logo} --> {$shop.logo}

@mgielecinski already modified in d40c7e2

in organization yes, but in line 60 still is error

@mgielecinski oh yeah I see :) Thx a lot. @Progi1984 for info I opened #24239 (pull request) to correct this based on mgielecinski laser eyes recommendation.

Typo in head-jsonld.tpl, shop logo link: correction for #23151

fdonnet requested a review from a team as a code owner February 5, 2021 09:27

prestonBot added develop Branch Improvement Type: Improvement labels Feb 5, 2021

fdonnet mentioned this pull request Feb 5, 2021

Remove microdata in html flow => replace per JSON-LD for classic theme #23042

Closed

This comment has been minimized.

Sign in to view

PierreRambaud changed the title ~~(REOPEN) Remove microdata in html flow => replace per JSON-LD for classic theme~~ Remove microdata in html flow => replace per JSON-LD for classic theme Feb 5, 2021

This comment has been minimized.

Sign in to view

NeOMakinG closed this Feb 11, 2021

NeOMakinG reopened this Feb 11, 2021

NeOMakinG closed this Feb 11, 2021

NeOMakinG reopened this Feb 11, 2021

Progi1984 reviewed Feb 15, 2021

View reviewed changes

themes/classic/templates/catalog/_partials/product-prices.tpl Outdated Show resolved Hide resolved

Progi1984 reviewed Feb 15, 2021

View reviewed changes

Progi1984 reviewed Feb 16, 2021

View reviewed changes

themes/classic/templates/catalog/_partials/product-prices.tpl Show resolved Hide resolved

Progi1984 reviewed Feb 16, 2021

View reviewed changes

Progi1984 previously approved these changes Feb 16, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Hlavtox mentioned this pull request Feb 17, 2021

Fix structured in last element of breadcrumbs #22704

Closed

Remove microdata => replace per JSON-LD for classic theme (include co…

1192ca3

…de cleaning - and correct files structure)

fdonnet dismissed Progi1984’s stale review via 1192ca3 March 1, 2021 13:05

fdonnet force-pushed the develop branch from 3931c94 to 1192ca3 Compare March 1, 2021 13:05

merge and adapte where old itemprop selectors are used for test and k…

0e741d7

…eep modification for SEO opti by NEOMaking

NeOMakinG reviewed Mar 1, 2021

View reviewed changes

themes/classic/templates/catalog/_partials/product-cover-thumbnails.tpl Outdated Show resolved Hide resolved

fdonnet dismissed stale reviews from Progi1984 and kpodemski via d40c7e2 March 24, 2021 13:50

NeOMakinG reviewed Mar 24, 2021

View reviewed changes

themes/classic/templates/_partials/microdata/head-jsonld.tpl Outdated Show resolved Hide resolved

NeOMakinG approved these changes Mar 24, 2021

View reviewed changes

NeOMakinG added QA ✔️ Status: check done, code approved and removed Waiting for author Status: action required, waiting for author feedback labels Mar 24, 2021

PrestaShop deleted a comment from prestashop-issue-bot bot Mar 24, 2021

NeOMakinG added this to the 1.7.8.0 milestone Mar 24, 2021

NeOMakinG closed this Mar 24, 2021

NeOMakinG reopened this Mar 24, 2021

Progi1984 approved these changes Mar 24, 2021

View reviewed changes

Progi1984 merged commit 89fc139 into PrestaShop:develop Mar 24, 2021

matks added the Key feature Notable feature to be highlighted label Mar 24, 2021

matks changed the title ~~Remove microdata in html flow => replace per JSON-LD for classic theme~~ Remove microdata in html flow and replace by JSON-LD for classic theme Mar 24, 2021

kpodemski mentioned this pull request Mar 30, 2021

Implementation of json-ld from 1.7.8 of Classic Oksydan/falcon#20

Closed

mgielecinski reviewed Apr 27, 2021

View reviewed changes

This was referenced Apr 27, 2021

Typo in head-jsonld.tpl, shop logo link : correction for #23151 #24233

Closed

Typo in head-jsonld.tpl, shop logo link: correction for #23151 #24239

Merged

Progi1984 added a commit that referenced this pull request May 12, 2021

Merge pull request #24239 from fdonnet/newfeature1.7.8.x

3fe7671

Typo in head-jsonld.tpl, shop logo link: correction for #23151

HanaRebaiQA mentioned this pull request Mar 3, 2022

SEO error ItemList position product list #27725

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove microdata in html flow and replace by JSON-LD for classic theme #23151

Remove microdata in html flow and replace by JSON-LD for classic theme #23151

fdonnet commented Feb 5, 2021 •

edited

prestonBot commented Feb 5, 2021

This comment has been minimized.

This comment has been minimized.

boubkerbribri commented Feb 8, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NeOMakinG commented Feb 11, 2021

NeOMakinG commented Feb 11, 2021

Progi1984 left a comment

Progi1984 left a comment

This comment has been minimized.

NeOMakinG left a comment

prestonBot commented Mar 24, 2021

NeOMakinG commented Mar 24, 2021

fdonnet commented Mar 24, 2021

NeOMakinG commented Mar 24, 2021

prestonBot commented Mar 24, 2021

Progi1984 commented Mar 24, 2021

prestashop-issue-bot bot commented Mar 24, 2021

Hlavtox commented Mar 24, 2021

fdonnet commented Mar 24, 2021 •

edited

Progi1984 commented Mar 25, 2021

mgielecinski Apr 27, 2021

fdonnet Apr 27, 2021

mgielecinski Apr 27, 2021

fdonnet Apr 27, 2021 •

edited

Remove microdata in html flow and replace by JSON-LD for classic theme #23151

Remove microdata in html flow and replace by JSON-LD for classic theme #23151

Conversation

fdonnet commented Feb 5, 2021 • edited

prestonBot commented Feb 5, 2021

This comment has been minimized.

This comment has been minimized.

boubkerbribri commented Feb 8, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NeOMakinG commented Feb 11, 2021

NeOMakinG commented Feb 11, 2021

Progi1984 left a comment

Choose a reason for hiding this comment

Progi1984 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

NeOMakinG left a comment

Choose a reason for hiding this comment

prestonBot commented Mar 24, 2021

NeOMakinG commented Mar 24, 2021

fdonnet commented Mar 24, 2021

NeOMakinG commented Mar 24, 2021

prestonBot commented Mar 24, 2021

Progi1984 commented Mar 24, 2021

prestashop-issue-bot bot commented Mar 24, 2021

Hlavtox commented Mar 24, 2021

fdonnet commented Mar 24, 2021 • edited

Progi1984 commented Mar 25, 2021

mgielecinski Apr 27, 2021

Choose a reason for hiding this comment

fdonnet Apr 27, 2021

Choose a reason for hiding this comment

mgielecinski Apr 27, 2021

Choose a reason for hiding this comment

fdonnet Apr 27, 2021 • edited

Choose a reason for hiding this comment

fdonnet commented Feb 5, 2021 •

edited

fdonnet commented Mar 24, 2021 •

edited

fdonnet Apr 27, 2021 •

edited