Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23250 #23253

Closed
wants to merge 2 commits into from
Closed

Fixes #23250 #23253

wants to merge 2 commits into from

Conversation

oopen
Copy link

@oopen oopen commented Feb 13, 2021 •
edited by Progi1984

Questions Answers
Branch? develop
Description? Fix url generation bux in production v1.7.7.1, include locale as root dir with index.php after.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #23250.
How to test? Active multi-lang, go to product, change variation
Possible impacts? Front URLs

This change is Reviewable

@oopen oopen requested a review from a team as a code owner February 13, 2021 22:25
@prestonBot
Copy link
Collaborator

Hello @oopen!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added Bug fix Type: Bug fix develop Branch labels Feb 13, 2021
Progi1984
Progi1984 reviewed Feb 15, 2021
View reviewed changes
classes/Link.php Outdated Show resolved Hide resolved
PierreRambaud
PierreRambaud suggested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thank you for your contribution.
Could you take a short time to read our Contribution Guidelines.
You have to run PHP Cs fixer to make code cleaner :)

@oopen oopen closed this Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 left review comments

@PierreRambaud PierreRambaud PierreRambaud requested changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 on Product Variantes change with multi-languages on classic theme
4 participants
@oopen @prestonBot @PierreRambaud @Progi1984