Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $to and $toName type in docblock #23272

Merged
merged 2 commits into from Feb 16, 2021

Conversation

RomainMazB
Copy link
Contributor

@RomainMazB RomainMazB commented Feb 16, 2021

Questions Answers
Branch? develop
Description? Just a comment fix to ease IDE analysis
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Doesn't fix anything
How to test? There is nothing more to test
Possible impacts? Absolutely not

This change is Reviewable

@RomainMazB RomainMazB requested a review from a team as a code owner February 16, 2021 08:38
@prestonBot
Copy link
Collaborator

Hello @RomainMazB!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The type should be one of these: new feature, improvement, bug fix or refacto (Read explanation).
  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)
  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

classes/Mail.php Outdated Show resolved Hide resolved
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment

Co-authored-by: Progi1984 <progi1984@gmail.com>
@Progi1984 Progi1984 added the Documentation ✔️ Developer documentation is up-to-date label Feb 16, 2021
@prestonBot prestonBot added the develop Branch label Feb 16, 2021
@RomainMazB
Copy link
Contributor Author

I'm okay with that: I'm not working with PS for so long, dunno yet the code style.

@PierreRambaud PierreRambaud merged commit 3a02992 into PrestaShop:develop Feb 16, 2021
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@PierreRambaud
Copy link
Contributor

Thank you @RomainMazB

@PierreRambaud PierreRambaud added this to the 1.7.8.0 milestone Feb 16, 2021
@prestonBot prestonBot added the Improvement Type: Improvement label Mar 24, 2021
@matks matks added Needs documentation Needs an update of the developer documentation and removed Documentation ✔️ Developer documentation is up-to-date labels Mar 25, 2022
@kpodemski kpodemski removed the Needs documentation Needs an update of the developer documentation label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants